Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: extensions/common/manifest_handlers/externally_connectable_unittest.cc

Issue 314113010: Remove deprecated permissions functions from Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_set.h ('k') | extensions/common/manifest_handlers/shared_module_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handlers/externally_connectable_unittest.cc
diff --git a/extensions/common/manifest_handlers/externally_connectable_unittest.cc b/extensions/common/manifest_handlers/externally_connectable_unittest.cc
index 41b2d32608904891a3fa825af4ab03515f448290..77acf35ddd786e8b5731b5cf632ff50023f499e5 100644
--- a/extensions/common/manifest_handlers/externally_connectable_unittest.cc
+++ b/extensions/common/manifest_handlers/externally_connectable_unittest.cc
@@ -9,6 +9,7 @@
#include "extensions/common/error_utils.h"
#include "extensions/common/manifest_constants.h"
#include "extensions/common/manifest_handlers/externally_connectable.h"
+#include "extensions/common/permissions/permissions_data.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -38,7 +39,8 @@ TEST_F(ExternallyConnectableTest, IDsAndMatches) {
LoadAndExpectSuccess("externally_connectable_ids_and_matches.json");
ASSERT_TRUE(extension.get());
- EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kWebConnectable));
+ EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(
+ APIPermission::kWebConnectable));
ExternallyConnectableInfo* info =
ExternallyConnectableInfo::Get(extension.get());
@@ -99,7 +101,8 @@ TEST_F(ExternallyConnectableTest, IDs) {
LoadAndExpectSuccess("externally_connectable_ids.json");
ASSERT_TRUE(extension.get());
- EXPECT_FALSE(extension->HasAPIPermission(APIPermission::kWebConnectable));
+ EXPECT_FALSE(extension->permissions_data()->HasAPIPermission(
+ APIPermission::kWebConnectable));
ExternallyConnectableInfo* info =
ExternallyConnectableInfo::Get(extension.get());
@@ -119,7 +122,8 @@ TEST_F(ExternallyConnectableTest, Matches) {
LoadAndExpectSuccess("externally_connectable_matches.json");
ASSERT_TRUE(extension.get());
- EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kWebConnectable));
+ EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(
+ APIPermission::kWebConnectable));
ExternallyConnectableInfo* info =
ExternallyConnectableInfo::Get(extension.get());
@@ -161,7 +165,8 @@ TEST_F(ExternallyConnectableTest, MatchesWithTlsChannelId) {
"externally_connectable_matches_tls_channel_id.json");
ASSERT_TRUE(extension.get());
- EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kWebConnectable));
+ EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(
+ APIPermission::kWebConnectable));
ExternallyConnectableInfo* info =
ExternallyConnectableInfo::Get(extension.get());
@@ -185,7 +190,8 @@ TEST_F(ExternallyConnectableTest, AllIDs) {
LoadAndExpectSuccess("externally_connectable_all_ids.json");
ASSERT_TRUE(extension.get());
- EXPECT_FALSE(extension->HasAPIPermission(APIPermission::kWebConnectable));
+ EXPECT_FALSE(extension->permissions_data()->HasAPIPermission(
+ APIPermission::kWebConnectable));
ExternallyConnectableInfo* info =
ExternallyConnectableInfo::Get(extension.get());
« no previous file with comments | « extensions/common/extension_set.h ('k') | extensions/common/manifest_handlers/shared_module_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698