chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 314113010: Remove deprecated permissions functions from Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 314113010: Remove deprecated permissions functions from Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index 5fc874720b9860bc8c1413569786a99b8112d29e..f7377047eea198b7752969664dc028753455440a 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -65,6 +65,7 @@

#include "extensions/common/manifest_handlers/icons_handler.h"

#include "extensions/common/manifest_handlers/incognito_info.h"

#include "extensions/common/manifest_handlers/offline_enabled_info.h"

+#include "extensions/common/permissions/permissions_data.h"

#include "extensions/common/switches.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

@@ -747,7 +748,8 @@ bool DeveloperPrivateShowPermissionsDialogFunction::RunSync() {

// Released by InstallUIAbort or InstallUIProceed.

AddRef();

std::vector<base::FilePath> retained_file_paths;

- if (extension->HasAPIPermission(APIPermission::kFileSystem)) {

+ if (extension->permissions_data()->HasAPIPermission(

+ APIPermission::kFileSystem)) {

std::vector<apps::SavedFileEntry> retained_file_entries =

apps::SavedFilesService::Get(GetProfile())

->GetAllFileEntries(extension_id_);