chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc - Issue 314113010: Remove deprecated permissions functions from Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc

Issue 314113010: Remove deprecated permissions functions from Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/content_settings_handler.cc ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc

index b8c4e5ff6cc37cb1a76e5161cb0d61ea6f1e3030..2091280bc2cfc0e42d4bcc498b730818d033e2a7 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc

@@ -5,6 +5,7 @@

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

#include "extensions/common/extension.h"

+#include "extensions/common/permissions/permissions_data.h"

#include "testing/gtest/include/gtest/gtest.h"

// Tests that the old permission name "unlimited_storage" still works for

@@ -13,6 +14,6 @@ TEST_F(ExtensionManifestTest, OldUnlimitedStoragePermission) {

scoped_refptr<extensions::Extension> extension = LoadAndExpectSuccess(

"old_unlimited_storage.json", extensions::Manifest::INTERNAL,

extensions::Extension::NO_FLAGS);

- EXPECT_TRUE(extension->HasAPIPermission(

+ EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(

extensions::APIPermission::kUnlimitedStorage));

}