chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 314113010: Remove deprecated permissions functions from Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 314113010: Remove deprecated permissions functions from Extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_cache_delegate.cc ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index 4a6660a374f2dd44c28f49afecb14c353180c6b1..dff53b70748946cee16f70251b08f75872c7cf5a 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -23,6 +23,7 @@

#include "extensions/browser/value_store/testing_value_store.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest_constants.h"

+#include "extensions/common/permissions/permissions_data.h"

#include "testing/gtest/include/gtest/gtest.h"

using extension_test_util::LoadManifestUnchecked;

@@ -348,8 +349,8 @@ TEST_F(RulesRegistryWithCacheTest, RulesPreservedAcrossRestart) {

ASSERT_TRUE(error.empty());

extension_service->AddExtension(extension.get());

EXPECT_TRUE(extension_service->extensions()->Contains(extension->id()));

- EXPECT_TRUE(

- extension->HasAPIPermission(APIPermission::kDeclarativeWebRequest));

+ EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(

+ APIPermission::kDeclarativeWebRequest));

env_.GetExtensionSystem()->SetReady();

// 2. First run, adding a rule for the extension.