Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed)

Created:
6 years, 6 months ago by chrishenry
Modified:
6 years, 6 months ago
Reviewers:
nednguyen, dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

ActionRunner API cleanup: 1) BeginInteraction+EndInteraction becomes interaction = action_runner.BeginInteraction(...) interaction.End() 2) Add action_runner.ExecuteJavaScript. 3) Replaced all existing use cases. Other cleanups: 1) s/JavascriptAction/JavaScriptAction/ 2) s/GetJavascriptMarker/GetJavaScriptMarker/ BUG=361809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275341

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -96 lines) Patch
M tools/perf/measurements/smoothness_controller.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tools/perf/page_sets/calendar_forward_backward.py View 1 chunk +7 lines, -10 lines 0 comments Download
M tools/perf/page_sets/gmail_compose_discard.py View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/perf/page_sets/image_decoding_measurement.py View 1 chunk +1 line, -4 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 1 5 chunks +8 lines, -9 lines 0 comments Download
M tools/perf/page_sets/polymer.py View 2 chunks +4 lines, -10 lines 0 comments Download
M tools/perf/page_sets/top_10.py View 1 chunk +6 lines, -6 lines 0 comments Download
M tools/perf/page_sets/top_25.py View 1 chunk +7 lines, -10 lines 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 chunk +1 line, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 1 3 chunks +68 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 3 chunks +10 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/all_page_actions.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/page/actions/gesture_action.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/javascript.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
chrishenry
6 years, 6 months ago (2014-06-05 19:03:23 UTC) #1
nednguyen
lgtm BeginInteraction(name="...", is_smooth=True)...
6 years, 6 months ago (2014-06-05 20:37:02 UTC) #2
chrishenry
Address TODO as we discussed earlier.
6 years, 6 months ago (2014-06-05 21:18:30 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-05 21:21:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/313383002/60001
6 years, 6 months ago (2014-06-05 21:23:52 UTC) #5
dtu
@chromium.org lgtm
6 years, 6 months ago (2014-06-05 22:23:20 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 01:48:49 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 02:45:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/39101)
6 years, 6 months ago (2014-06-06 02:45:55 UTC) #9
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-06 02:49:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/313383002/60001
6 years, 6 months ago (2014-06-06 02:52:08 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 05:29:25 UTC) #12
Message was sent while issue was closed.
Change committed as 275341

Powered by Google App Engine
This is Rietveld 408576698