Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: tools/perf/page_sets/calendar_forward_backward.py

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/timeline_controller.py ('k') | tools/perf/page_sets/gmail_compose_discard.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/calendar_forward_backward.py
diff --git a/tools/perf/page_sets/calendar_forward_backward.py b/tools/perf/page_sets/calendar_forward_backward.py
index 0e369a3b8674c13d4e245745231b658b4a3dfcbd..f4ca483ef41e3f2a0499d1a2fbfcac4b62e07ead 100644
--- a/tools/perf/page_sets/calendar_forward_backward.py
+++ b/tools/perf/page_sets/calendar_forward_backward.py
@@ -32,16 +32,13 @@ class CalendarForwardBackwardPage(page_module.Page):
'condition': 'element',
'selector': 'div[class~="navForward"]'
}))
- action_runner.RunAction(JavascriptAction(
- {
- 'expression': '''
- (function() {
- var elem = document.createElement('meta');
- elem.name='viewport';
- elem.content='initial-scale=1';
- document.body.appendChild(elem);
- })();'''
- }))
+ action_runner.ExecuteJavaScript('''
+ (function() {
+ var elem = document.createElement('meta');
+ elem.name='viewport';
+ elem.content='initial-scale=1';
+ document.body.appendChild(elem);
+ })();''')
def RunEndure(self, action_runner):
action_runner.RunAction(ClickElementAction(
« no previous file with comments | « tools/perf/measurements/timeline_controller.py ('k') | tools/perf/page_sets/gmail_compose_discard.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698