tools/perf/page_sets/webrtc_cases.py - Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/webrtc_cases.py

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/webrtc_cases.py

diff --git a/tools/perf/page_sets/webrtc_cases.py b/tools/perf/page_sets/webrtc_cases.py

index aac321cc66f2ce9049ee6a434e3810ec99c11c1a..54c8f48b4fa72170e089a49ba466eb1b52935117 100644

--- a/tools/perf/page_sets/webrtc_cases.py

+++ b/tools/perf/page_sets/webrtc_cases.py

@@ -28,10 +28,7 @@ class Page1(WebrtcCasesPage):

{

'seconds': 10

}))

- action_runner.RunAction(JavascriptAction(

- {

- 'expression': 'checkForErrors();'

- }))

+ action_runner.ExecuteJavaScript('checkForErrors();')

class Page2(WebrtcCasesPage):

« no previous file with comments | « tools/perf/page_sets/top_25.py ('k') | tools/telemetry/telemetry/page/actions/action_runner.py » ('j') | no next file with comments »