Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: tools/perf/measurements/smoothness_controller.py

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/timeline_controller.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/smoothness_controller.py
diff --git a/tools/perf/measurements/smoothness_controller.py b/tools/perf/measurements/smoothness_controller.py
index fd38609fa07853f51337dce0c8c4bd0e243eb92c..0739a8d177fd12e8ef9e7308c11404cffa0bfa59 100644
--- a/tools/perf/measurements/smoothness_controller.py
+++ b/tools/perf/measurements/smoothness_controller.py
@@ -23,6 +23,7 @@ class SmoothnessController(object):
def __init__(self):
self._timeline_model = None
self._tracing_timeline_data = None
+ self._interaction = None
def Start(self, page, tab):
custom_categories = ['webkit.console', 'benchmark']
@@ -32,12 +33,12 @@ class SmoothnessController(object):
tab.browser.platform.StartRawDisplayFrameRateMeasurement()
# Start the smooth marker for all smooth actions.
runner = action_runner.ActionRunner(tab)
- runner.BeginInteraction(RUN_SMOOTH_ACTIONS, [tir_module.IS_SMOOTH])
+ self._interaction = runner.BeginInteraction(
+ RUN_SMOOTH_ACTIONS, is_smooth=True)
def Stop(self, tab):
# End the smooth marker for all smooth actions.
- runner = action_runner.ActionRunner(tab)
- runner.EndInteraction(RUN_SMOOTH_ACTIONS, [tir_module.IS_SMOOTH])
+ self._interaction.End()
# Stop tracing for smoothness metric.
if tab.browser.platform.IsRawDisplayFrameRateSupported():
tab.browser.platform.StopRawDisplayFrameRateMeasurement()
« no previous file with comments | « no previous file | tools/perf/measurements/timeline_controller.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698