tools/telemetry/telemetry/page/actions/javascript.py - Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/javascript.py

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/actions/gesture_action.py ('k') | tools/telemetry/telemetry/web_perf/timeline_interaction_record.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/actions/javascript.py

diff --git a/tools/telemetry/telemetry/page/actions/javascript.py b/tools/telemetry/telemetry/page/actions/javascript.py

index 4bd8d6b367f990f882fbeea3252327d258fb2bf9..8a0bb092f3290899ae0c95ffbe906ab2a0a6f728 100644

--- a/tools/telemetry/telemetry/page/actions/javascript.py

+++ b/tools/telemetry/telemetry/page/actions/javascript.py

@@ -5,9 +5,9 @@

from telemetry.page.actions import page_action

-class JavascriptAction(page_action.PageAction):

+class JavaScriptAction(page_action.PageAction):

def __init__(self, attributes=None):

- super(JavascriptAction, self).__init__(attributes)

+ super(JavaScriptAction, self).__init__(attributes)

def RunAction(self, tab):

assert hasattr(self, 'expression')