tools/telemetry/telemetry/page/actions/all_page_actions.py - Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/all_page_actions.py

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/actions/action_runner_unittest.py ('k') | tools/telemetry/telemetry/page/actions/gesture_action.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/actions/all_page_actions.py

diff --git a/tools/telemetry/telemetry/page/actions/all_page_actions.py b/tools/telemetry/telemetry/page/actions/all_page_actions.py

index 25fd7cfca9bf7d49dbdd5601be51c01205984e66..6e698276469a622d1ecb29f16c5292cac9330218 100644

--- a/tools/telemetry/telemetry/page/actions/all_page_actions.py

+++ b/tools/telemetry/telemetry/page/actions/all_page_actions.py

@@ -11,7 +11,6 @@ from telemetry.page.actions import page_action

# TODO(nednguyen): Remove all of these imports when we done porting all actions

# to action_runner

from telemetry.page.actions.interact import InteractAction

-from telemetry.page.actions.javascript import JavascriptAction

from telemetry.page.actions.javascript_click import ClickElementAction

from telemetry.page.actions.js_collect_garbage import JsCollectGarbageAction

from telemetry.page.actions.loop import LoopAction