Cleanup interaction creation and add ExecuteJavaScript to action_runner.py

tools/perf/page_sets/key_silk_cases.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 # pylint: disable=W0401,W0614
 from telemetry.page.actions.all_page_actions import *
 from telemetry.page import page as page_module
 from telemetry.page import page_set as page_set_module
-from telemetry.web_perf import timeline_interaction_record as tir_module
 
 
 class KeySilkCasesPage(page_module.Page):
 
   def __init__(self, url, page_set):
     super(KeySilkCasesPage, self).__init__(url=url, page_set=page_set)
     self.credentials_path = 'data/credentials.json'
     self.user_agent_type = 'mobile'
     self.archive_data_file = 'data/key_silk_cases.json'
 
@@ skipping 273 matching lines @@
         'left_start_percentage': 0.8,
         'distance': 200,
         'direction': 'left',
         'top_start_percentage': 0.2,
         'element_function': '''
           function(callback) {
             callback(document.getElementsByClassName('message')[2]);
           }''',
         'speed': 5000
       }))
-    action_runner.BeginInteraction('Wait', [tir_module.IS_SMOOTH])
+    interaction = action_runner.BeginInteraction('Wait', is_smooth=True)
     action_runner.RunAction(WaitAction({
       'javascript': 'document.getElementsByClassName("message").length < 18'
     }))
-    action_runner.EndInteraction('Wait', [tir_module.IS_SMOOTH])
+    interaction.End()
 
   def RunSmoothness(self, action_runner):
     self.SwipeToDismiss(action_runner)
 
 
 class Page17(KeySilkCasesPage):
 
   def __init__(self, page_set):
     super(Page17, self).__init__(
       url='file://key_silk_cases/inbox_app.html?stress_hidey_bars',
@@ skipping 67 matching lines @@
   def __init__(self, page_set):
     super(Page19, self).__init__(
       url='file://key_silk_cases/inbox_app.html?slide_drawer',
       page_set=page_set)
 
   def ToggleDrawer(self, action_runner):
     action_runner.RunAction(TapAction(
       {
         'selector': '#menu-button'
       }))
-    action_runner.BeginInteraction('Wait', [tir_module.IS_SMOOTH])
+    interaction = action_runner.BeginInteraction('Wait', is_smooth=True)
     action_runner.RunAction(WaitAction({
       'javascript': 'document.getElementById("nav-drawer").active'
     }))
-    action_runner.EndInteraction('Wait', [tir_module.IS_SMOOTH])
+    interaction.End()
 
 
   def RunNavigateSteps(self, action_runner):
     action_runner.NavigateToPage(self)
     action_runner.RunAction(WaitAction({'seconds': 2}))
     self.ToggleDrawer(action_runner)
 
   def RunSmoothness(self, action_runner):
     self.SlideDrawer(action_runner)
 
@@ skipping 119 matching lines @@
       page_set=page_set)
 
   def RunSmoothness(self, action_runner):
     action_runner.RunAction(ScrollAction(
       {
         'direction': 'down',
         'scroll_requires_touch': True,
         'scroll_distance_function':
           'function() { return window.innerHeight / 2; }'
       }))
-    action_runner.BeginInteraction('Wait', [tir_module.IS_SMOOTH])
+    interaction = action_runner.BeginInteraction('Wait', is_smooth=True)
     action_runner.RunAction(WaitAction({'seconds' : 1}))
-    action_runner.EndInteraction('Wait', [tir_module.IS_SMOOTH])
+    interaction.End()
 
 
 class Page24(KeySilkCasesPage):
 
   """
   Why: Google News: this iOS version is slower than accelerated scrolling
   """
 
   def __init__(self, page_set):
     super(Page24, self).__init__(
@@ skipping 42 matching lines @@
   def RunSmoothness(self, action_runner):
     action_runner.RunAction(SwipeAction(
       {
         'distance': 100,
         'direction': "left",
         'element_function': '''
           function(callback) {
             callback(document.getElementById(':f'));
           }'''
       }))
-    action_runner.BeginInteraction('Wait', [tir_module.IS_SMOOTH])
+    interaction = action_runner.BeginInteraction('Wait', is_smooth=True)
     action_runner.RunAction(WaitAction({'seconds' : 1}))
-    action_runner.EndInteraction('Wait', [tir_module.IS_SMOOTH])
+    interaction.End()
 
 
 class Page26(KeySilkCasesPage):
 
   """ Why: famo.us twitter demo """
 
   def __init__(self, page_set):
     super(Page26, self).__init__(
       url='http://s.codepen.io/befamous/fullpage/pFsqb?scroll',
       page_set=page_set)
@@ skipping 45 matching lines @@
     self.AddPage(Page17(self))
     self.AddPage(Page18(self))
     self.AddPage(Page19(self))
     self.AddPage(Page20(self))
     self.AddPage(Page21(self))
     self.AddPage(Page22(self))
     self.AddPage(Page23(self))
     self.AddPage(Page24(self))
     self.AddPage(Page25(self))
     self.AddPage(Page26(self))