Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: tools/perf/measurements/timeline_controller.py

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/smoothness_controller.py ('k') | tools/perf/page_sets/calendar_forward_backward.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/timeline_controller.py
diff --git a/tools/perf/measurements/timeline_controller.py b/tools/perf/measurements/timeline_controller.py
index aa1c6bbab667bb3c5a0a215eee0c01f664b1a1c4..b34ec4fa390c925996d6e8e857c6f36d5927b9f4 100644
--- a/tools/perf/measurements/timeline_controller.py
+++ b/tools/perf/measurements/timeline_controller.py
@@ -19,6 +19,7 @@ class TimelineController(object):
self._model = None
self._renderer_process = None
self._smooth_records = []
+ self._interaction = None
def Start(self, page, tab):
"""Starts gathering timeline data.
@@ -37,12 +38,12 @@ class TimelineController(object):
tab.browser.StartTracing(','.join(categories))
# Start the smooth marker for all actions.
runner = action_runner.ActionRunner(tab)
- runner.BeginInteraction(RUN_SMOOTH_ACTIONS, [tir_module.IS_SMOOTH])
+ self._interaction = runner.BeginInteraction(
+ RUN_SMOOTH_ACTIONS, is_smooth=True)
def Stop(self, tab):
# End the smooth marker for all actions.
- runner = action_runner.ActionRunner(tab)
- runner.EndInteraction(RUN_SMOOTH_ACTIONS, [tir_module.IS_SMOOTH])
+ self._interaction.End()
# Stop tracing.
timeline_data = tab.browser.StopTracing()
self._model = TimelineModel(timeline_data)
« no previous file with comments | « tools/perf/measurements/smoothness_controller.py ('k') | tools/perf/page_sets/calendar_forward_backward.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698