tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py - Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py

index d8ffb97771b5a2e801e1688c285fde982577742c..8a30d193a82bd55ad2d8332b6d1bc7fba045c490 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py

@@ -59,11 +59,11 @@ class TimelineInteractionRecordTests(unittest.TestCase):

self.assertEquals(True, r.is_smooth)

self.assertEquals(True, r.is_responsive)

- def testGetJavascriptMarker(self):

- smooth_marker = tir_module.TimelineInteractionRecord.GetJavascriptMarker(

+ def testGetJavaScriptMarker(self):

+ smooth_marker = tir_module.TimelineInteractionRecord.GetJavaScriptMarker(

'LogicalName', [tir_module.IS_SMOOTH])

self.assertEquals('Interaction.LogicalName/is_smooth', smooth_marker)

- slr_marker = tir_module.TimelineInteractionRecord.GetJavascriptMarker(

+ slr_marker = tir_module.TimelineInteractionRecord.GetJavaScriptMarker(

'LogicalName', [tir_module.IS_SMOOTH, tir_module.IS_RESPONSIVE])

self.assertEquals('Interaction.LogicalName/is_smooth,is_responsive',

slr_marker)

« no previous file with comments | « tools/telemetry/telemetry/web_perf/timeline_interaction_record.py ('k') | no next file » | no next file with comments »