tools/perf/page_sets/top_10.py - Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/top_10.py

Issue 313383002: Cleanup interaction creation and add ExecuteJavaScript to action_runner.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/top_10.py

diff --git a/tools/perf/page_sets/top_10.py b/tools/perf/page_sets/top_10.py

index 34ffd1114b495a20c521d6b6c69cf2214825b552..0668d79116dc2a789dbd88202f903ec3c496ef71 100644

--- a/tools/perf/page_sets/top_10.py

+++ b/tools/perf/page_sets/top_10.py

@@ -49,12 +49,12 @@ class GoogleCalendar(SimpleScrollPage):

def RunNavigateSteps(self, action_runner):

super(GoogleCalendar, self).RunNavigateSteps(action_runner)

- action_runner.RunAction(JavascriptAction(

- { 'expression' :

- '(function() { var elem = document.createElement("meta");'

- 'elem.name="viewport";'

- 'elem.content="initial-scale=1";'

- 'document.body.appendChild(elem); })();'}))

+ action_runner.ExecuteJavaScript('''

+ (function() { var elem = document.createElement("meta");

+ elem.name="viewport";

+ elem.content="initial-scale=1";

+ document.body.appendChild(elem);

+ })();''')

action_runner.RunAction(WaitAction({'seconds' : 2}))

action_runner.RunAction(WaitAction({

'condition' : 'element', 'selector' : 'div[class~="navForward"]'}))

« no previous file with comments | « tools/perf/page_sets/polymer.py ('k') | tools/perf/page_sets/top_25.py » ('j') | no next file with comments »