Remove deprecated_internalProblem.

Remove deprecated_internalProblem.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/de891789da1a74ae9911c2d3c9785cc6fe94b5c9

[ahe, 2017-07-11 12:37:55]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-07-11 18:34:06]

lgtm

https://codereview.chromium.org/2974933002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_target.dart (right):

https://codereview.chromium.org/2974933002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_target.dart:47: return new
Future<Null>.sync(() => unsupported("buildProgram", -1, null));
Should this have been an 'unimplemented' ?

https://codereview.chromium.org/2974933002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart (right):

https://codereview.chromium.org/2974933002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart:493: Expression
buildSimpleRead() {
Here and many below: Should it be 'unhandled' instead of 'unsupported'?

[ahe, 2017-07-12 14:04:02]

Thank you, Johnni!

https://codereview.chromium.org/2974933002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/dill/dill_target.dart (right):

https://codereview.chromium.org/2974933002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/dill/dill_target.dart:47: return new
Future<Null>.sync(() => unsupported("buildProgram", -1, null));
On 2017/07/11 18:34:05, Johnni Winther wrote:
> Should this have been an 'unimplemented' ?

By now it's an unsupported operation. I know this because I don't have any
crashes because of this.

https://codereview.chromium.org/2974933002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart (right):

https://codereview.chromium.org/2974933002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart:493: Expression
buildSimpleRead() {
On 2017/07/11 18:34:05, Johnni Winther wrote:
> Here and many below: Should it be 'unhandled' instead of 'unsupported'?

Similar reasoning: I know now that this is unsupported as I have no crashes due
to these methods.

[ahe, 2017-07-12 14:28:09]

Description was changed from

==========
Remove deprecated_internalProblem.
==========

to

==========
Remove deprecated_internalProblem.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/de891789da1a74ae9911c2d3c9785cc6fe94b5c9
==========

[ahe, 2017-07-12 14:28:10]

Committed patchset #1 (id:1) manually as
de891789da1a74ae9911c2d3c9785cc6fe94b5c9 (presubmit successful).