Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart

Issue 2974933002: Remove deprecated_internalProblem. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
index 267dde41a5fe27d2d8301a9306e0dc38ee478398..cbc3d5493e744b9e08251b7015abbc7e689bce03 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
@@ -4,15 +4,6 @@
library fasta.kernel_procedure_builder;
-import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart'
- show KernelProcedure;
-
-import 'package:front_end/src/fasta/source/source_library_builder.dart'
- show SourceLibraryBuilder;
-
-import 'package:front_end/src/fasta/type_inference/type_inference_listener.dart'
- show TypeInferenceListener;
-
import 'package:kernel/ast.dart'
show
Arguments,
@@ -44,11 +35,20 @@ import 'package:kernel/ast.dart'
import 'package:kernel/type_algebra.dart' show containsTypeVariable, substitute;
-import '../deprecated_problems.dart' show deprecated_internalProblem;
+import '../loader.dart' show Loader;
-import '../messages.dart' show messageNonInstanceTypeVariableUse, warning;
+import '../messages.dart'
+ show
+ messageInternalProblemBodyOnAbstractMethod,
+ messageNonInstanceTypeVariableUse,
+ warning;
-import '../loader.dart' show Loader;
+import '../problems.dart' show internalProblem;
+
+import '../source/source_library_builder.dart' show SourceLibraryBuilder;
+
+import '../type_inference/type_inference_listener.dart'
+ show TypeInferenceListener;
import 'kernel_builder.dart'
show
@@ -67,6 +67,8 @@ import 'kernel_builder.dart'
isRedirectingGenerativeConstructorImplementation,
deprecated_memberError;
+import 'kernel_shadow_ast.dart' show KernelProcedure;
+
abstract class KernelFunctionBuilder
extends ProcedureBuilder<KernelTypeBuilder> {
final String nativeMethodName;
@@ -91,8 +93,8 @@ abstract class KernelFunctionBuilder
void set body(Statement newBody) {
if (newBody != null) {
if (isAbstract) {
- return deprecated_internalProblem(
- "Attempting to set body on abstract method.");
+ return internalProblem(messageInternalProblemBodyOnAbstractMethod,
+ newBody.fileOffset, fileUri);
}
if (isExternal) {
return library.deprecated_addCompileTimeError(

Powered by Google App Engine
This is Rietveld 408576698