Remove prefixes from messages and document why.

Remove prefixes from messages and document why.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/20ffc179b70a7b4765c81d0de013fe366e56e6b6

[ahe, 2017-07-11 12:57:02]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-07-11 18:35:23]

lgtm

[ahe, 2017-07-12 15:18:10]

Description was changed from

==========
Remove prefixes from messages and document why.
==========

to

==========
Remove prefixes from messages and document why.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/20ffc179b70a7b4765c81d0de013fe366e56e6b6
==========

[ahe, 2017-07-12 15:18:12]

Committed patchset #1 (id:1) manually as
20ffc179b70a7b4765c81d0de013fe366e56e6b6 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-07-12 20:36:59]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-07-12 20:37:00]

https://codereview.chromium.org/2974203002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2974203002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:21: # "InternalProblem". This way, UX review can
prioritize it accordingly.
should we also have a boolean property on Code/Message for internal errors as
well? (make it easier for code to easily sort through them)

[ahe, 2017-07-13 00:17:06]

Thank you, Siggi!

https://codereview.chromium.org/2974203002/diff/1/pkg/front_end/messages.yaml
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2974203002/diff/1/pkg/front_end/messages.yaml...
pkg/front_end/messages.yaml:21: # "InternalProblem". This way, UX review can
prioritize it accordingly.
On 2017/07/12 20:37:00, Siggi Cherem (dart-lang) wrote:
> should we also have a boolean property on Code/Message for internal errors as
> well? (make it easier for code to easily sort through them)

Good question. I can't make up my mind right now. I've created an enum for
severity that currently looks like this:

enum Severity {
  error,
  internalProblem,
  nit,
  warning,
}

I don't want to hard-code severity in the Message objects, and it feels clunky
to add a withSeverity method. I hope you can help me sort this out in our next
1:1.