Implement more message argument kinds.

Implement more message argument kinds.

R=johnniwinther@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a66d0c797af81d959a355dd290b8598f8e9fca6f

[ahe, 2017-07-11 11:57:08]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[Johnni Winther, 2017-07-11 18:58:48]

lgtm

[Siggi Cherem (dart-lang), 2017-07-11 21:25:27]

lgtm

https://codereview.chromium.org/2977653003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/fasta_codes.dart (right):

https://codereview.chromium.org/2977653003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/fasta_codes.dart:93: // (otherwise, we might get an
`UNUSED_IMPORT` warning).
Note that for #1 is enough to add a dartdoc reference too :)

/// [relativizeUri] may be used in the generated code.
import 'util/relativize.dart' show relativizeUri;

the alternative could be to switch fasta_code_generates to be a library and not
a part, and include the import if you see a #uri in any message

https://codereview.chromium.org/2977653003/diff/1/pkg/front_end/tool/_fasta/g...
File pkg/front_end/tool/_fasta/generate_messages.dart (right):

https://codereview.chromium.org/2977653003/diff/1/pkg/front_end/tool/_fasta/g...
pkg/front_end/tool/_fasta/generate_messages.dart:92: case "#string2":
How about `#kind:n` to make it a bit more flexible? Basically `#kind` ==
`#kind:0`,

[ahe, 2017-07-12 12:42:13]

Thank you, Johnni and Siggi!

https://codereview.chromium.org/2977653003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/fasta_codes.dart (right):

https://codereview.chromium.org/2977653003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/fasta_codes.dart:93: // (otherwise, we might get an
`UNUSED_IMPORT` warning).
On 2017/07/11 21:25:27, Siggi Cherem (dart-lang) wrote:
> Note that for #1 is enough to add a dartdoc reference too :)
> 
> /// [relativizeUri] may be used in the generated code.
> import 'util/relativize.dart' show relativizeUri;
> 
> the alternative could be to switch fasta_code_generates to be a library and
not
> a part, and include the import if you see a #uri in any message

Acknowledged.

https://codereview.chromium.org/2977653003/diff/1/pkg/front_end/tool/_fasta/g...
File pkg/front_end/tool/_fasta/generate_messages.dart (right):

https://codereview.chromium.org/2977653003/diff/1/pkg/front_end/tool/_fasta/g...
pkg/front_end/tool/_fasta/generate_messages.dart:92: case "#string2":
On 2017/07/11 21:25:27, Siggi Cherem (dart-lang) wrote:
> How about `#kind:n` to make it a bit more flexible? Basically `#kind` ==
> `#kind:0`,

This has been annoying me as well, but I'll deal with it later as I have a bunch
of CLs on top of this :-)

[ahe, 2017-07-12 13:03:59]

Description was changed from

==========
Implement more message argument kinds.
==========

to

==========
Implement more message argument kinds.

R=johnniwinther@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a66d0c797af81d959a355dd290b8598f8e9fca6f
==========

[ahe, 2017-07-12 13:04:00]

Committed patchset #1 (id:1) manually as
a66d0c797af81d959a355dd290b8598f8e9fca6f (presubmit successful).