Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart

Issue 2974933002: Remove deprecated_internalProblem. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
index 5fa005af74f1d41168dbaf943de40c529664105c..ea534462ee41c073ded96b735b125f86084a1d87 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
@@ -4,9 +4,6 @@
library fasta.kernel_class_builder;
-import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart'
- show KernelMember;
-
import 'package:kernel/ast.dart'
show
Class,
@@ -27,11 +24,11 @@ import 'package:kernel/ast.dart'
import 'package:kernel/class_hierarchy.dart' show ClassHierarchy;
-import '../deprecated_problems.dart' show deprecated_internalProblem;
+import '../dill/dill_member_builder.dart' show DillMemberBuilder;
import '../fasta_codes.dart' show templateRedirectionTargetNotFound;
-import '../dill/dill_member_builder.dart' show DillMemberBuilder;
+import '../problems.dart' show unhandled, unimplemented;
import 'kernel_builder.dart'
show
@@ -49,6 +46,8 @@ import 'kernel_builder.dart'
TypeVariableBuilder,
computeDefaultTypeArguments;
+import 'kernel_shadow_ast.dart' show KernelMember;
+
import 'redirecting_factory_body.dart' show RedirectingFactoryBody;
abstract class KernelClassBuilder
@@ -84,7 +83,7 @@ abstract class KernelClassBuilder
for (KernelTypeBuilder builder in arguments) {
DartType type = builder.build(library);
if (type == null) {
- deprecated_internalProblem("Bad type: ${builder.runtimeType}");
+ unhandled("${builder.runtimeType}", "buildTypeArguments", -1, null);
}
typeArguments.add(type);
}
@@ -190,8 +189,8 @@ abstract class KernelClassBuilder
void checkOverride(
Member declaredMember, Member interfaceMember, bool isSetter) {
if (declaredMember is Constructor || interfaceMember is Constructor) {
- deprecated_internalProblem(
- "Constructor in override check.", fileUri, declaredMember.fileOffset);
+ unimplemented(
+ "Constructor in override check.", declaredMember.fileOffset, fileUri);
}
if (declaredMember is Procedure && interfaceMember is Procedure) {
if (declaredMember.kind == ProcedureKind.Method &&

Powered by Google App Engine
This is Rietveld 408576698