Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2974933002: Remove deprecated_internalProblem. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
index ce22ac87d99c903c19ca7af157274f87d2c054fb..641e4353356fb5d66d8dfe8c4c810760e0a995b1 100644
--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
@@ -6,31 +6,16 @@ library fasta.outline_builder;
import 'package:kernel/ast.dart' show ProcedureKind;
-import '../fasta_codes.dart' show Message, codeExpectedBlockToSkip;
-
-import '../parser/parser.dart' show FormalParameterType, MemberKind, optional;
-
-import '../parser/identifier_context.dart' show IdentifierContext;
-
import '../../scanner/token.dart' show Token;
-import '../util/link.dart' show Link;
+import '../builder/builder.dart';
import '../combinator.dart' show Combinator;
-import '../deprecated_problems.dart' show deprecated_internalProblem;
-
-import '../builder/builder.dart';
+import '../fasta_codes.dart' show Message, codeExpectedBlockToSkip;
import '../modifier.dart' show abstractMask, externalMask, Modifier;
-import 'source_library_builder.dart' show SourceLibraryBuilder;
-
-import 'unhandled_listener.dart' show NullValue, Unhandled, UnhandledListener;
-
-import '../parser/native_support.dart'
- show extractNativeMethodName, removeNativeClause, skipNativeClause;
-
import '../operator.dart'
show
Operator,
@@ -38,8 +23,23 @@ import '../operator.dart'
operatorToString,
operatorRequiredArgumentCount;
+import '../parser/identifier_context.dart' show IdentifierContext;
+
+import '../parser/native_support.dart'
+ show extractNativeMethodName, removeNativeClause, skipNativeClause;
+
+import '../parser/parser.dart' show FormalParameterType, MemberKind, optional;
+
+import '../problems.dart' show unhandled, unimplemented;
+
import '../quote.dart' show unescapeString;
+import '../util/link.dart' show Link;
+
+import 'source_library_builder.dart' show SourceLibraryBuilder;
+
+import 'unhandled_listener.dart' show NullValue, Unhandled, UnhandledListener;
+
enum MethodBody {
Abstract,
Regular,
@@ -206,7 +206,7 @@ class OutlineBuilder extends UnhandledListener {
push(unescapeString(token.lexeme));
push(token.charOffset);
} else {
- deprecated_internalProblem("String interpolation not implemented.");
+ unimplemented("string interpolation", endToken.charOffset, uri);
}
}
@@ -295,7 +295,8 @@ class OutlineBuilder extends UnhandledListener {
if (token == null) return ProcedureKind.Method;
if (optional("get", token)) return ProcedureKind.Getter;
if (optional("set", token)) return ProcedureKind.Setter;
- return deprecated_internalProblem("Unhandled: ${token.lexeme}");
+ return unhandled(
+ token.lexeme, "computeProcedureKind", token.charOffset, uri);
}
@override

Powered by Google App Engine
This is Rietveld 408576698