Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: pkg/front_end/lib/src/fasta/quote.dart

Issue 2974933002: Remove deprecated_internalProblem. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/quote.dart
diff --git a/pkg/front_end/lib/src/fasta/quote.dart b/pkg/front_end/lib/src/fasta/quote.dart
index a044216622cfef7d68bd532ee8930763894d16b1..ac3eaa75473a57711f2d93de628ab23077e14ddd 100644
--- a/pkg/front_end/lib/src/fasta/quote.dart
+++ b/pkg/front_end/lib/src/fasta/quote.dart
@@ -4,8 +4,9 @@
library fasta.quote;
-import 'deprecated_problems.dart'
- show deprecated_inputError, deprecated_internalProblem;
+import 'deprecated_problems.dart' show deprecated_inputError;
+
+import 'problems.dart' show unhandled;
import 'scanner/characters.dart'
show
@@ -50,7 +51,7 @@ Quote analyzeQuote(String first) {
if (first.startsWith('r"')) return Quote.RawDouble;
if (first.startsWith("'")) return Quote.Single;
if (first.startsWith("r'")) return Quote.RawSingle;
- return deprecated_internalProblem("Unexpected string literal: $first");
+ return unhandled(first, "analyzeQuote", -1, null);
}
// Note: based on [StringValidator.quotingFromString]
@@ -100,7 +101,7 @@ int firstQuoteLength(String first, Quote quote) {
case Quote.RawMultiLineDouble:
return lengthOfOptionalWhitespacePrefix(first, 4);
}
- return deprecated_internalProblem("Unhandled string quote: $quote");
+ return unhandled("$quote", "firstQuoteLength", -1, null);
}
int lastQuoteLength(Quote quote) {
@@ -117,7 +118,7 @@ int lastQuoteLength(Quote quote) {
case Quote.RawMultiLineDouble:
return 3;
}
- return deprecated_internalProblem("Unhandled string quote: $quote");
+ return unhandled("$quote", "lastQuoteLength", -1, null);
}
String unescapeFirstStringPart(String first, Quote quote) {
@@ -161,8 +162,7 @@ String unescape(String string, Quote quote) {
? string
: unescapeCodeUnits(string.codeUnits, true);
}
- return deprecated_internalProblem(
- "Internal error: Unexpected quote: $quote.");
+ return unhandled("$quote", "unescape", -1, null);
}
const String incompleteSequence = "Incomplete escape sequence.";

Powered by Google App Engine
This is Rietveld 408576698