Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

Issue 2974933002: Remove deprecated_internalProblem. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
index 84269fea839dbeee1dc76262e5111fcce5bd6232..c51de80a9e8150fbae94c51f5c688ff12636377c 100644
--- a/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
@@ -3,8 +3,7 @@
// BSD-style license that can be found in the LICENSE.md file.
import 'package:front_end/src/base/instrumentation.dart';
-import 'package:front_end/src/fasta/deprecated_problems.dart'
- show deprecated_internalProblem;
+import 'package:front_end/src/fasta/problems.dart' show unhandled;
import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart';
import 'package:front_end/src/fasta/names.dart' show callName;
import 'package:front_end/src/fasta/type_inference/type_inference_engine.dart';
@@ -369,8 +368,11 @@ abstract class TypeInferrerImpl extends TypeInferrer {
}
return interfaceMember;
} else {
- throw deprecated_internalProblem(
- 'Unexpected invocation type: ${methodInvocation.runtimeType}');
+ throw unhandled(
+ "${methodInvocation.runtimeType}",
+ "findMethodInvocationMember",
+ methodInvocation.fileOffset,
+ Uri.parse(uri));
}
}
@@ -397,8 +399,8 @@ abstract class TypeInferrerImpl extends TypeInferrer {
}
return interfaceMember;
} else {
- throw deprecated_internalProblem(
- 'Unexpected propertyGet type: ${propertyGet.runtimeType}');
+ return unhandled("${propertyGet.runtimeType}", "findPropertyGetMember",
+ propertyGet.fileOffset, Uri.parse(uri));
}
}
@@ -423,8 +425,8 @@ abstract class TypeInferrerImpl extends TypeInferrer {
}
return interfaceMember;
} else {
- throw deprecated_internalProblem(
- 'Unexpected propertySet type: ${propertySet.runtimeType}');
+ throw unhandled("${propertySet.runtimeType}", "findPropertySetMember",
+ propertySet.fileOffset, Uri.parse(uri));
}
}

Powered by Google App Engine
This is Rietveld 408576698