Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

Issue 2974933002: Remove deprecated_internalProblem. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
index 5f952a790f0530559d7c87980c05074c90632444..fb1eabf3c56db855f16a796f0f7b7b5ab4601a81 100644
--- a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
@@ -5,7 +5,17 @@
/// A library to help transform compounds and null-aware accessors into
/// let expressions.
-import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart'
+import 'package:kernel/ast.dart' hide MethodInvocation, InvalidExpression;
+
+import '../../scanner/token.dart' show Token;
+
+import '../names.dart' show equalsName, indexGetName, indexSetName;
+
+import '../problems.dart' show unhandled;
+
+import 'fasta_accessors.dart' show BuilderHelper;
+
+import 'kernel_shadow_ast.dart'
show
KernelArguments,
KernelComplexAssignment,
@@ -21,18 +31,7 @@ import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart'
KernelVariableDeclaration,
KernelVariableGet;
-import 'package:front_end/src/fasta/kernel/utils.dart' show offsetForToken;
-
-import 'package:front_end/src/scanner/token.dart' show Token;
-
-import 'package:front_end/src/fasta/kernel/fasta_accessors.dart'
- show BuilderHelper;
-
-import 'package:kernel/ast.dart' hide MethodInvocation, InvalidExpression;
-
-import '../names.dart' show equalsName, indexGetName, indexSetName;
-
-import '../deprecated_problems.dart' show deprecated_internalProblem;
+import 'utils.dart' show offsetForToken;
/// An [Accessor] represents a subexpression for which we can't yet build a
/// kernel [Expression] because we don't yet know the context in which it is
@@ -178,8 +177,8 @@ abstract class Accessor {
///
/// At runtime, an exception will be thrown.
makeInvalidRead() {
- return deprecated_internalProblem(
- "Unhandled compile-time error.", null, offsetForToken(token));
+ return unhandled("compile-time error", "$runtimeType",
+ offsetForToken(token), helper.uri);
}
/// Returns an [Expression] representing a compile-time error wrapping
@@ -187,8 +186,8 @@ abstract class Accessor {
///
/// At runtime, [value] will be evaluated before throwing an exception.
makeInvalidWrite(Expression value) {
- return deprecated_internalProblem(
- "Unhandled compile-time error.", null, offsetForToken(token));
+ return unhandled("compile-time error", "$runtimeType",
+ offsetForToken(token), helper.uri);
}
/// Creates a data structure for tracking the desugaring of a complex

Powered by Google App Engine
This is Rietveld 408576698