Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: pkg/front_end/lib/src/fasta/builder/class_builder.dart

Issue 2974933002: Remove deprecated_internalProblem. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/class_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/class_builder.dart b/pkg/front_end/lib/src/fasta/builder/class_builder.dart
index 7e64fda6e281f2c2fcd570e8c0d5e979f87c2e79..f3cd77a21662820beb1546cb6e0dcb9ff9ef858f 100644
--- a/pkg/front_end/lib/src/fasta/builder/class_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/class_builder.dart
@@ -4,7 +4,7 @@
library fasta.class_builder;
-import '../deprecated_problems.dart' show deprecated_internalProblem;
+import '../problems.dart' show internalProblem;
import 'builder.dart'
show
@@ -21,7 +21,11 @@ import 'builder.dart'
TypeDeclarationBuilder,
TypeVariableBuilder;
-import '../fasta_codes.dart' show Message;
+import '../fasta_codes.dart'
+ show
+ Message,
+ templateInternalProblemNotFoundIn,
+ templateInternalProblemSuperclassNotFound;
abstract class ClassBuilder<T extends TypeBuilder, R>
extends TypeDeclarationBuilder<T, R> {
@@ -166,10 +170,11 @@ abstract class ClassBuilder<T extends TypeBuilder, R>
}
supertype = t.supertype;
} else {
- deprecated_internalProblem(
- "Superclass not found '${superclass.fullNameForErrors}'.",
- fileUri,
- charOffset);
+ internalProblem(
+ templateInternalProblemSuperclassNotFound
+ .withArguments(superclass.fullNameForErrors),
+ charOffset,
+ fileUri);
}
if (variables != null) {
Map<TypeVariableBuilder, TypeBuilder> directSubstitutionMap =
@@ -197,7 +202,11 @@ abstract class ClassBuilder<T extends TypeBuilder, R>
MemberBuilder operator [](String name) {
// TODO(ahe): Rename this to getLocalMember.
return scope.local[name] ??
- deprecated_internalProblem("Not found: '$name'.");
+ internalProblem(
+ templateInternalProblemNotFoundIn.withArguments(
+ name, fullNameForErrors),
+ -1,
+ null);
}
void addCompileTimeError(Message message, int charOffset) {

Powered by Google App Engine
This is Rietveld 408576698