Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)

Created:
3 years, 5 months ago by the real yoland
Modified:
3 years, 5 months ago
CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, jbudorick+watch_chromium.org, kalyank, mikecase+watch_chromium.org, sadrul, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify CommandLine parameterizing J3 Instrumentation Tests Since WebView is the only place where parameterization is used for instrumentation tests. This CL simplify the framework by only providing commandline flag parameterization. This is for the sake of listing out tests from Java test runner side in the follow up CL BUG=640116 Review-Url: https://codereview.chromium.org/2963683002 Cr-Commit-Position: refs/heads/master@{#486821} Committed: https://chromium.googlesource.com/chromium/src/+/7b7faaec17ca9db15a7e6aaec5dbb4db8e48c5c5

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simplify CommandLine parameterizing J3 Instrumentation Tests #

Total comments: 4

Patch Set 3 : address bo's comments #

Patch Set 4 : remove logs #

Patch Set 5 : Change host side runner #

Total comments: 3

Patch Set 6 : Change omnibox tests #

Patch Set 7 : remove unnecessary changes in host script #

Total comments: 13

Patch Set 8 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -2683 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java View 1 2 3 4 5 6 7 3 chunks +6 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 2 3 4 5 6 7 6 chunks +6 lines, -6 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwDebugTest.java View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 1 2 3 4 5 6 7 2 chunks +4 lines, -18 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java View 1 2 3 4 5 6 7 3 chunks +3 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java View 1 2 3 4 5 6 7 3 chunks +5 lines, -8 lines 0 comments Download
M base/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -5 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseActivityInstrumentationTestCase.java View 1 2 3 4 5 6 7 2 chunks +1 line, -65 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseTestResult.java View 2 chunks +0 lines, -255 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java View 2 chunks +0 lines, -33 lines 0 comments Download
D base/test/android/javatests/src/org/chromium/base/test/util/parameter/BaseParameter.java View 1 chunk +0 lines, -80 lines 0 comments Download
A base/test/android/javatests/src/org/chromium/base/test/util/parameter/CommandLineParameter.java View 1 2 3 4 5 6 7 1 chunk +32 lines, -0 lines 0 comments Download
D base/test/android/javatests/src/org/chromium/base/test/util/parameter/Parameter.java View 1 1 chunk +0 lines, -199 lines 0 comments Download
D base/test/android/javatests/src/org/chromium/base/test/util/parameter/Parameterizable.java View 1 chunk +0 lines, -36 lines 0 comments Download
D base/test/android/javatests/src/org/chromium/base/test/util/parameter/ParameterizedTest.java View 1 chunk +0 lines, -32 lines 0 comments Download
A base/test/android/javatests/src/org/chromium/base/test/util/parameter/SkipCommandLineParameterization.java View 1 2 3 4 5 6 7 1 chunk +23 lines, -0 lines 0 comments Download
D base/test/android/javatests/src/org/chromium/base/test/util/parameter/parameters/MethodParameter.java View 1 chunk +0 lines, -21 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 2 3 4 5 6 7 9 chunks +21 lines, -72 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 2 3 4 5 6 7 5 chunks +6 lines, -9 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 4 5 6 7 2 chunks +0 lines, -9 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/base/test/util/parameter/ParameterizedTestAnnotationTest.java View 1 2 3 1 chunk +0 lines, -388 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/base/test/util/parameter/ParameterizedTestClassAnnotationInheritanceTest.java View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/base/test/util/parameter/ParameterizedTestClassAnnotationParameterSetAndTest.java View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/base/test/util/parameter/ParameterizedTestClassAnnotationParametersTest.java View 1 2 3 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/base/test/util/parameter/ParameterizedTestClassAnnotationParametersTestSetInheritanceTest.java View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/base/test/util/parameter/ParameterizedTestClassAnnotationParametersTestSetTest.java View 1 2 3 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/base/test/util/parameter/ParameterizedTestClassAnnotationTest.java View 1 2 3 1 chunk +0 lines, -84 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java View 1 2 3 4 5 6 7 2 chunks +5 lines, -15 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/UrlBarTest.java View 1 2 3 4 5 6 7 2 chunks +5 lines, -15 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/test/ParametersOnMultiTest.java View 1 2 3 1 chunk +0 lines, -557 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/test/util/parameters/SigninParametersTest.java View 1 2 3 1 chunk +0 lines, -201 lines 0 comments Download
M chrome/test/android/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java View 1 2 3 4 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java View 1 2 3 2 chunks +1 line, -77 lines 0 comments Download
D chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddFakeAccountToAppParameter.java View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddFakeAccountToOsParameter.java View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddGoogleAccountToOsParameter.java View 1 chunk +0 lines, -56 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 59 (37 generated)
the real yoland
sorry Sean... https://codereview.chromium.org/2963683002/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/2963683002/diff/1/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode427 build/android/pylib/instrumentation/instrumentation_test_instance.py:427: display_name = '%s__%s' % (display_name, test['flags']) this ...
3 years, 5 months ago (2017-06-28 01:23:09 UTC) #2
boliu
https://codereview.chromium.org/2963683002/diff/60001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java (right): https://codereview.chromium.org/2963683002/diff/60001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java#newcode64 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java:64: @SkipParameterization clang-format did this? so ugly :/ https://codereview.chromium.org/2963683002/diff/60001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java File ...
3 years, 5 months ago (2017-06-28 04:40:13 UTC) #5
the real yoland
https://codereview.chromium.org/2963683002/diff/60001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java (right): https://codereview.chromium.org/2963683002/diff/60001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java#newcode64 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java:64: @SkipParameterization On 2017/06/28 at 04:40:12, boliu wrote: > clang-format ...
3 years, 5 months ago (2017-06-28 18:16:45 UTC) #6
boliu
rs lgtm, assuming new annotation still does the same thing
3 years, 5 months ago (2017-06-28 18:29:11 UTC) #7
the real yoland
friendly ping
3 years, 5 months ago (2017-07-11 00:04:18 UTC) #10
the real yoland
Add +changwan for changes in omnibox tests
3 years, 5 months ago (2017-07-11 00:58:24 UTC) #15
Changwan Ryu
On 2017/07/11 00:58:24, the real yoland wrote: > Add +changwan for changes in omnibox tests ...
3 years, 5 months ago (2017-07-11 02:56:58 UTC) #22
the real yoland
On 2017/07/11 at 02:56:58, changwan wrote: > On 2017/07/11 00:58:24, the real yoland wrote: > ...
3 years, 5 months ago (2017-07-11 03:16:35 UTC) #25
Changwan Ryu
https://codereview.chromium.org/2963683002/diff/200001/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java (right): https://codereview.chromium.org/2963683002/diff/200001/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java#newcode79 chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java:79: "enable-features=" + ChromeFeatureList.SPANNABLE_INLINE_AUTOCOMPLETE}) Hmm... If we have to choose ...
3 years, 5 months ago (2017-07-11 04:36:42 UTC) #26
the real yoland
https://codereview.chromium.org/2963683002/diff/200001/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java (right): https://codereview.chromium.org/2963683002/diff/200001/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java#newcode79 chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java:79: "enable-features=" + ChromeFeatureList.SPANNABLE_INLINE_AUTOCOMPLETE}) On 2017/07/11 at 04:36:42, Changwan Ryu ...
3 years, 5 months ago (2017-07-11 17:46:51 UTC) #27
mikecase (-- gone --)
lgtm https://codereview.chromium.org/2963683002/diff/120001/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/2963683002/diff/120001/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode36 build/android/pylib/instrumentation/instrumentation_test_instance.py:36: _VALID_ANNOTATIONS = set(['Manual', 'PerfTest'] + _DEFAULT_ANNOTATIONS + What ...
3 years, 5 months ago (2017-07-11 18:16:19 UTC) #28
Changwan Ryu
On 2017/07/11 17:46:51, the real yoland wrote: > https://codereview.chromium.org/2963683002/diff/200001/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java > File > chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java > (right): ...
3 years, 5 months ago (2017-07-11 23:17:29 UTC) #29
jbudorick
lgtm w/ nits https://codereview.chromium.org/2963683002/diff/200001/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (left): https://codereview.chromium.org/2963683002/diff/200001/build/android/pylib/instrumentation/instrumentation_test_instance.py#oldcode292 build/android/pylib/instrumentation/instrumentation_test_instance.py:292: nit: please don't pull the second ...
3 years, 5 months ago (2017-07-13 18:45:54 UTC) #30
the real yoland
add +tedchoc for chrome/ OWNER's stamp https://codereview.chromium.org/2963683002/diff/120001/build/android/pylib/instrumentation/instrumentation_test_instance.py File build/android/pylib/instrumentation/instrumentation_test_instance.py (right): https://codereview.chromium.org/2963683002/diff/120001/build/android/pylib/instrumentation/instrumentation_test_instance.py#newcode36 build/android/pylib/instrumentation/instrumentation_test_instance.py:36: _VALID_ANNOTATIONS = set(['Manual', ...
3 years, 5 months ago (2017-07-13 23:49:19 UTC) #41
Ted C
chrome - owners - lgtm
3 years, 5 months ago (2017-07-14 00:00:29 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963683002/260001
3 years, 5 months ago (2017-07-14 16:54:17 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/490107)
3 years, 5 months ago (2017-07-14 17:04:57 UTC) #49
the real yoland
add +rmcilroy for base/BUILD.gn owner stamp
3 years, 5 months ago (2017-07-14 18:09:27 UTC) #51
the real yoland
add +torne for base/BUILD.gn owner stamp
3 years, 5 months ago (2017-07-14 18:25:42 UTC) #53
Torne
base/BUILD.gn LGTM
3 years, 5 months ago (2017-07-14 18:35:01 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963683002/260001
3 years, 5 months ago (2017-07-14 18:35:41 UTC) #56
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 18:53:40 UTC) #59
Message was sent while issue was closed.
Committed patchset #8 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/7b7faaec17ca9db15a7e6aaec5db...

Powered by Google App Engine
This is Rietveld 408576698