Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5413)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)
Patch Set: address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
index 60899e8d8f4dec34392897de493019c6f86ab003..84d146aab2a1ef86b048e54f18a6eb63087a3f0d 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java
@@ -12,7 +12,6 @@ import android.view.View;
import org.chromium.base.test.BaseActivityInstrumentationTestCase;
import org.chromium.base.test.util.CommandLineFlags;
-import org.chromium.base.test.util.parameter.BaseParameter;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.infobar.InfoBar;
@@ -21,14 +20,10 @@ import org.chromium.chrome.browser.preferences.Preferences;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.test.ChromeActivityTestCommon.ChromeTestCommonCallback;
import org.chromium.chrome.test.util.ApplicationTestUtils;
-import org.chromium.chrome.test.util.parameters.AddFakeAccountToAppParameter;
-import org.chromium.chrome.test.util.parameters.AddFakeAccountToOsParameter;
-import org.chromium.chrome.test.util.parameters.AddGoogleAccountToOsParameter;
import org.chromium.content.browser.test.util.TestTouchUtils;
import org.chromium.content.browser.test.util.TouchCommon;
import java.util.List;
-import java.util.Map;
import java.util.concurrent.TimeoutException;
/**
@@ -376,18 +371,6 @@ public abstract class ChromeActivityTestCaseBase<T extends ChromeActivity>
return mTestCommon.runJavaScriptCodeInCurrentTab(code);
}
- @Override
- protected Map<String, BaseParameter> createAvailableParameters() {
- Map<String, BaseParameter> availableParameters = super.createAvailableParameters();
- availableParameters.put(AddFakeAccountToAppParameter.PARAMETER_TAG,
- new AddFakeAccountToAppParameter(getParameterReader(), getInstrumentation()));
- availableParameters.put(AddFakeAccountToOsParameter.PARAMETER_TAG,
- new AddFakeAccountToOsParameter(getParameterReader(), getInstrumentation()));
- availableParameters.put(AddGoogleAccountToOsParameter.PARAMETER_TAG,
- new AddGoogleAccountToOsParameter(getParameterReader(), getInstrumentation()));
- return availableParameters;
- }
-
/**
* Waits till the ContentViewCore receives the expected page scale factor
* from the compositor and asserts that this happens.
« no previous file with comments | « chrome/test/android/BUILD.gn ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698