Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)
Patch Set: address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java
index 5fb81ffc42a10019deafd7f4e263773696eb694d..724bc0f7332e7b7f64efdf6ae26f0ed2031a0138 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java
@@ -14,7 +14,7 @@ import org.chromium.android_webview.policy.AwPolicyProvider;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
-import org.chromium.base.test.util.parameter.ParameterizedTest;
+import org.chromium.base.test.util.parameter.SkipCommandLineParameterization;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
import org.chromium.net.test.util.TestWebServer;
import org.chromium.policy.AbstractAppRestrictionsProvider;
@@ -63,7 +63,7 @@ public class PolicyUrlFilteringTest extends AwTestBase {
@MediumTest
@Feature({"AndroidWebView", "Policy"})
// Run in single process only. crbug.com/615484
- @ParameterizedTest.Set
+ @SkipCommandLineParameterization
@RetryOnFailure
public void testBlacklistedUrl() throws Throwable {
final AwPolicyProvider testProvider =
@@ -91,7 +91,7 @@ public class PolicyUrlFilteringTest extends AwTestBase {
@Policies.Item(key = sBlacklistPolicyName, stringArray = {"*"}),
@Policies.Item(key = sWhitelistPolicyName, stringArray = {sFooWhitelistFilter})})
// Run in single process only. crbug.com/660517
- @ParameterizedTest.Set
+ @SkipCommandLineParameterization
public void testWhitelistedUrl() throws Throwable {
navigateAndCheckOutcome(mFooTestUrl, 0 /* error count before */, 0 /* error count after */);

Powered by Google App Engine
This is Rietveld 408576698