Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4444)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddGoogleAccountToOsParameter.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)
Patch Set: address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddFakeAccountToOsParameter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddGoogleAccountToOsParameter.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddGoogleAccountToOsParameter.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddGoogleAccountToOsParameter.java
deleted file mode 100644
index 34a359725a93801bc0bcc1c215d22087c797fdbf..0000000000000000000000000000000000000000
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddGoogleAccountToOsParameter.java
+++ /dev/null
@@ -1,56 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.test.util.parameters;
-
-import android.app.Instrumentation;
-
-import org.chromium.base.test.util.parameter.BaseParameter;
-import org.chromium.base.test.util.parameter.Parameter;
-import org.chromium.chrome.test.util.ChromeSigninUtils;
-
-/**
- * Adds a Google account to OS when this parameter is used.
- */
-public class AddGoogleAccountToOsParameter extends BaseParameter {
- /** Adds a Google account to OS to run test as signed into the OS. */
- public static final String PARAMETER_TAG = "add-google-account-to-os-parameter";
-
- /** The {@Parameter.Argument#name()} value. */
- public static final class ARGUMENT {
- public static final String USERNAME = "username";
- public static final String PASSWORD = "password";
- public static final String TYPE = "type";
- private static final class DEFAULT {
- private static final String TYPE = "mail";
- }
- }
-
- private ChromeSigninUtils mSigninUtil;
-
- public AddGoogleAccountToOsParameter(Parameter.Reader parameterReader,
- Instrumentation instrumentation) {
- super(PARAMETER_TAG, parameterReader);
- mSigninUtil = new ChromeSigninUtils(instrumentation);
- }
-
- @Override
- public void setUp() {
- String username = getStringArgument(ARGUMENT.USERNAME);
- String password = getStringArgument(ARGUMENT.PASSWORD);
- String type = getStringArgument(ARGUMENT.TYPE, ARGUMENT.DEFAULT.TYPE);
-
- mSigninUtil.removeAllGoogleAccountsFromOs();
- mSigninUtil.addGoogleAccountToOs(username, password, type);
- }
-
- @Override
- public void tearDown() {
- mSigninUtil.removeAllGoogleAccountsFromOs();
- }
-
- public boolean isSignedIn(String username) {
- return mSigninUtil.isExistingGoogleAccountOnOs(username);
- }
-}
« no previous file with comments | « chrome/test/android/javatests/src/org/chromium/chrome/test/util/parameters/AddFakeAccountToOsParameter.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698