Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)
Patch Set: address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java
index 373be1fc42ec5cf2a5c0fbedd81a97a2ed8629c7..b63c4ed4ba6eaf937349ec3748053365a2163da6 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/crash/VisualStateCallbackTest.java
@@ -27,7 +27,7 @@ import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.RetryOnFailure;
-import org.chromium.base.test.util.parameter.ParameterizedTest;
+import org.chromium.base.test.util.parameter.SkipCommandLineParameterization;
import org.chromium.content_public.common.ContentUrlConstants;
import java.util.concurrent.TimeUnit;
@@ -152,9 +152,8 @@ public class VisualStateCallbackTest extends AwTestBase {
// process gone, but before the AwContentsClient knows about it.
@Feature({"AndroidWebView"})
@SmallTest
- @CommandLineFlags
- .Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
+ @SkipCommandLineParameterization
public void testAddVisualStateCallbackAfterRendererGone() throws Throwable {
final VisualStateCallbackImpl vsImpl = new VisualStateCallbackImpl();
mHelper.setOnRenderProcessGoneTask(new Runnable() {
@@ -177,11 +176,9 @@ public class VisualStateCallbackTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@RetryOnFailure
- @CommandLineFlags
- .Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
+ @SkipCommandLineParameterization
public void testVisualStateCallbackNotCalledAfterRendererGone() throws Throwable {
-
VisualStateCallbackImpl vsImpl = new VisualStateCallbackImpl();
insertVisualStateCallbackOnUIThread(mAwContents, vsImpl.requestId(), vsImpl);
VisualStateCallbackHelper vsCallbackHelper = mAwContents.getVisualStateCallbackHelper();
« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java ('k') | base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698