Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)
Patch Set: address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
diff --git a/base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java b/base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
index a140ff16b351bddafbf174bc594acc3f8c57cc26..bd23f26705e738a94c05f88fb160c92342db3078 100644
--- a/base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
+++ b/base/test/android/javatests/src/org/chromium/base/test/util/CommandLineFlags.java
@@ -12,7 +12,6 @@ import org.junit.Rule;
import org.chromium.base.BaseChromiumApplication;
import org.chromium.base.CommandLine;
import org.chromium.base.test.BaseTestResult.PreTestHook;
-import org.chromium.base.test.util.parameter.BaseParameter;
import java.lang.annotation.ElementType;
import java.lang.annotation.Inherited;
@@ -168,36 +167,4 @@ public final class CommandLineFlags {
};
}
-
- /**
- * Instructs the test runner to execute the test with modified command-line flags.
- * Flags to add are specified using 'stringArray' of argument named 'add',
- * and flags to remove -- in the argument named 'remove'. A parameter without arguments
- * instructs to run the test with default command-line flags.
- *
- * Example:
- *
- * @ParameterizedTest.Set(tests = {
- * @ParameterizedTest(parameters = {
- * @Parameter( tag = CommandLineFlags.Parameter.PARAMETER_TAG)}),
- * @ParameterizedTest(parameters = {
- * @Parameter( tag = CommandLineFlags.Parameter.PARAMETER_TAG,
- * arguments = {
- * @Parameter.Argument( name = CommandLineFlags.Parameter.ADD_ARG,
- * stringArray = {'arg1', 'arg2'})
- * })})})
- *
- * Note that because the entire instrumentation test process needs to be restarted to apply
- * modified command-line arguments, this annotation is handled by test_runner.py, not by
- * BaseTestResult class.
- */
- public static class Parameter extends BaseParameter {
- public static final String PARAMETER_TAG = "cmdlinearg-parameter";
- public static final String ADD_ARG = "add";
- public static final String REMOVE_ARG = "remove";
-
- public Parameter(org.chromium.base.test.util.parameter.Parameter.Reader parameterReader) {
- super(PARAMETER_TAG, parameterReader);
- }
- }
}

Powered by Google App Engine
This is Rietveld 408576698