android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java - Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)

Patch Set: address comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

index 23a1c9ade29cd85567d50f8ff8c7b6e064807b96..2e562d182faefd85337d5247d31e9fdc093c7e5f 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientCallbackHelperTest.java

@@ -16,7 +16,7 @@ import org.chromium.android_webview.test.TestAwContentsClient.OnReceivedLoginReq

import org.chromium.android_webview.test.TestAwContentsClient.PictureListenerHelper;

import org.chromium.base.test.util.CallbackHelper;

import org.chromium.base.test.util.Feature;

-import org.chromium.base.test.util.parameter.ParameterizedTest;

+import org.chromium.base.test.util.parameter.SkipCommandLineParameterization;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageStartedHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnReceivedErrorHelper;

@@ -25,7 +25,7 @@ import java.util.concurrent.Callable;

/**

* Test suite for AwContentsClientCallbackHelper.

-@ParameterizedTest.Set // These are unit tests. No need to repeat for multiprocess.

+@SkipCommandLineParameterization // These are unit tests. No need to repeat for multiprocess.

public class AwContentsClientCallbackHelperTest extends AwTestBase {

/**

* Callback helper for OnLoadedResource.