Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3119)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)
Patch Set: address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
index e9a8012a395bcbd7683cc219f6193dd82dfd011e..ce3724696e9632de13e36ba7a489e717dcc18533 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
@@ -31,7 +31,7 @@ import org.chromium.base.process_launcher.ChildProcessConnection;
import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.Feature;
-import org.chromium.base.test.util.parameter.ParameterizedTest;
+import org.chromium.base.test.util.parameter.SkipCommandLineParameterization;
import org.chromium.content.browser.BindingManager;
import org.chromium.content.browser.ChildProcessLauncherHelper;
import org.chromium.content_public.common.ContentUrlConstants;
@@ -615,7 +615,7 @@ public class AwContentsTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @SkipCommandLineParameterization
public void testSandboxedRendererWorks() throws Throwable {
MockBindingManager bindingManager = new MockBindingManager();
ChildProcessLauncherHelper.setBindingManagerForTesting(bindingManager);
@@ -644,7 +644,7 @@ public class AwContentsTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @SkipCommandLineParameterization
public void testRendererPriorityStartsHigh() throws Throwable {
MockBindingManager bindingManager = new MockBindingManager();
ChildProcessLauncherHelper.setBindingManagerForTesting(bindingManager);
@@ -666,7 +666,7 @@ public class AwContentsTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @SkipCommandLineParameterization
public void testRendererPriorityLow() throws Throwable {
MockBindingManager bindingManager = new MockBindingManager();
ChildProcessLauncherHelper.setBindingManagerForTesting(bindingManager);
@@ -696,7 +696,7 @@ public class AwContentsTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
@CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @SkipCommandLineParameterization
public void testRendererPriorityManaged() throws Throwable {
MockBindingManager bindingManager = new MockBindingManager();
ChildProcessLauncherHelper.setBindingManagerForTesting(bindingManager);
@@ -729,7 +729,7 @@ public class AwContentsTest extends AwTestBase {
@SmallTest
@UiThreadTest
@CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @SkipCommandLineParameterization
public void testPauseDestroyResume() throws Throwable {
AwContents awContents;
awContents = createAwTestContainerView(mContentsClient).getAwContents();

Powered by Google App Engine
This is Rietveld 408576698