Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java

Issue 2963683002: Simplify CommandLine parameterizing J3 Instrumentation Tests (Closed)
Patch Set: address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
index 1e8a2bcdd6056f06e95d7d4e12e5c5399b37feb2..cc54555379979c9a5ff1bfe8ec52d69bf2f3a14d 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnRenderProcessGoneTest.java
@@ -14,7 +14,7 @@ import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
-import org.chromium.base.test.util.parameter.ParameterizedTest;
+import org.chromium.base.test.util.parameter.SkipCommandLineParameterization;
import java.util.concurrent.TimeUnit;
@@ -56,12 +56,11 @@ public class AwContentsClientOnRenderProcessGoneTest extends AwTestBase {
}
}
- @DisabledTest // http://crbug.com/689292
+ @DisabledTest // http://crbug.com/689292
@Feature({"AndroidWebView"})
@SmallTest
- @CommandLineFlags
- .Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
+ @SkipCommandLineParameterization
public void testOnRenderProcessCrash() throws Throwable {
RenderProcessGoneTestAwContentsClient contentsClient =
new RenderProcessGoneTestAwContentsClient();
@@ -80,9 +79,8 @@ public class AwContentsClientOnRenderProcessGoneTest extends AwTestBase {
@Feature({"AndroidWebView"})
@SmallTest
- @CommandLineFlags
- .Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
- @ParameterizedTest.Set
+ @CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
+ @SkipCommandLineParameterization
public void testOnRenderProcessKill() throws Throwable {
RenderProcessGoneTestAwContentsClient contentsClient =
new RenderProcessGoneTestAwContentsClient();

Powered by Google App Engine
This is Rietveld 408576698