Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2957983002: Remove pointless InProcessBrowserTest calls. (Closed)

Created:
3 years, 5 months ago by Lei Zhang
Modified:
3 years, 5 months ago
Reviewers:
benwells
CC:
chromium-reviews, skanuj+watch_chromium.org, sadrul, yusukes+watch_chromium.org, tzik, jered+watch_chromium.org, chfremer+watch_chromium.org, hidehiko+watch_chromium.org, poromov+watch_chromium.org, dougt+watch_chromium.org, lhchavez+watch_chromium.org, dmazzoni+watch_chromium.org, vakh+watch_chromium.org, timvolodine, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, awdf+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, achuith+watch_chromium.org, raymes+watch_chromium.org, net-reviews_chromium.org, nhiroki, je_julie, csharp+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, johnme+watch_chromium.org, alemate+watch_chromium.org, victorhsieh+watch_chromium.org, derat+watch_chromium.org, Peter Beverloo, joenotcharles+watch_chromium.org, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, samarth+watch_chromium.org, jfweitz+watch_chromium.org, aleventhal+watch_chromium.org, oshima+watch_chromium.org, kalyank, mlamouri+watch-permissions_chromium.org, sync-reviews_chromium.org, elijahtaylor+arcwatch_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, nektar+watch_chromium.org, tommycli, David Black, davemoore+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, kmadhusu+watch_chromium.org, ftirelo+watch_chromium.org, alito+watch_chromium.org, kinuko+fileapi, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pointless InProcessBrowserTest calls. InProcessBrowserTest is the base class and its SetUpCommandLine() method does not do anything. Same for SetUpInProcessBrowserTestFixture(), TearDownInProcessBrowserTestFixture(), and TearDownOnMainThread(). Review-Url: https://codereview.chromium.org/2957983002 Cr-Commit-Position: refs/heads/master@{#483084} Committed: https://chromium.googlesource.com/chromium/src/+/519c16766d8f596da9b4855e2b3bde7a23ea0a0d

Patch Set 1 #

Patch Set 2 : lint #

Patch Set 3 : build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -92 lines) Patch
M chrome/browser/app_controller_mac_browsertest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/budget_service/budget_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_controller_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/auth/arc_robot_auth_code_fetcher_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/mixin_based_browser_test.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/user_affiliation_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer_browsertest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/devtools/device/port_forwarding_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/predictor_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/payments/site_per_process_payments_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_request_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/permissions_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_command_controller_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/task_manager_mac_browsertest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/profile_error_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/local_ntp_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/usb/usb_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/web_bluetooth_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (14 generated)
Lei Zhang
Removing all the others in this round.
3 years, 5 months ago (2017-06-27 18:41:18 UTC) #10
benwells
lgtm
3 years, 5 months ago (2017-06-28 04:55:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957983002/40001
3 years, 5 months ago (2017-06-28 18:07:41 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 18:57:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/519c16766d8f596da9b4855e2b3b...

Powered by Google App Engine
This is Rietveld 408576698