Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Side by Side Diff: chrome/browser/ui/profile_error_browsertest.cc

Issue 2957983002: Remove pointless InProcessBrowserTest calls. (Closed)
Patch Set: build Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/files/file_util.h" 8 #include "base/files/file_util.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 if (base::WriteFile(pref_file, kUserProfileData.c_str(), 51 if (base::WriteFile(pref_file, kUserProfileData.c_str(),
52 kUserProfileData.size()) != 52 kUserProfileData.size()) !=
53 static_cast<int>(kUserProfileData.size())) { 53 static_cast<int>(kUserProfileData.size())) {
54 ADD_FAILURE(); 54 ADD_FAILURE();
55 return false; 55 return false;
56 } 56 }
57 return true; 57 return true;
58 } 58 }
59 59
60 void SetUpInProcessBrowserTestFixture() override { 60 void SetUpInProcessBrowserTestFixture() override {
61 InProcessBrowserTest::SetUpInProcessBrowserTestFixture();
62
63 // Skip showing the error message box in order to avoid freezing the main 61 // Skip showing the error message box in order to avoid freezing the main
64 // thread. 62 // thread.
65 chrome::internal::g_should_skip_message_box_for_test = true; 63 chrome::internal::g_should_skip_message_box_for_test = true;
66 } 64 }
67 65
68 protected: 66 protected:
69 // Histogram value verifier. 67 // Histogram value verifier.
70 const base::HistogramTester histogram_tester_; 68 const base::HistogramTester histogram_tester_;
71 69
72 // Whether the test fixture and test should set up a corrupted profile and 70 // Whether the test fixture and test should set up a corrupted profile and
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 histogram_tester_.ExpectTotalCount(kPaintHistogram, 1); 109 histogram_tester_.ExpectTotalCount(kPaintHistogram, 1);
112 histogram_tester_.ExpectTotalCount(kLoadHistogram, 1); 110 histogram_tester_.ExpectTotalCount(kLoadHistogram, 1);
113 } 111 }
114 } 112 }
115 113
116 INSTANTIATE_TEST_CASE_P(ProfileErrorBrowserTestInstance, 114 INSTANTIATE_TEST_CASE_P(ProfileErrorBrowserTestInstance,
117 ProfileErrorBrowserTest, 115 ProfileErrorBrowserTest,
118 testing::Bool()); 116 testing::Bool());
119 117
120 } // namespace 118 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/task_manager_mac_browsertest.mm ('k') | chrome/browser/ui/search/local_ntp_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698