Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc

Issue 2957983002: Remove pointless InProcessBrowserTest calls. (Closed)
Patch Set: build Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h" 5 #include "chrome/browser/chromeos/app_mode/kiosk_app_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 // Don't spin up the IO thread yet since no threads are allowed while 236 // Don't spin up the IO thread yet since no threads are allowed while
237 // spawning sandbox host process. See crbug.com/322732. 237 // spawning sandbox host process. See crbug.com/322732.
238 ASSERT_TRUE(embedded_test_server()->InitializeAndListen()); 238 ASSERT_TRUE(embedded_test_server()->InitializeAndListen());
239 239
240 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 240 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
241 241
242 InProcessBrowserTest::SetUp(); 242 InProcessBrowserTest::SetUp();
243 } 243 }
244 244
245 void SetUpCommandLine(base::CommandLine* command_line) override { 245 void SetUpCommandLine(base::CommandLine* command_line) override {
246 InProcessBrowserTest::SetUpCommandLine(command_line);
247
248 // Initialize fake_cws_ to setup web store gallery. 246 // Initialize fake_cws_ to setup web store gallery.
249 fake_cws_->Init(embedded_test_server()); 247 fake_cws_->Init(embedded_test_server());
250 } 248 }
251 249
252 void SetUpOnMainThread() override { 250 void SetUpOnMainThread() override {
253 host_resolver()->AddRule("*", "127.0.0.1"); 251 host_resolver()->AddRule("*", "127.0.0.1");
254 252
255 // Start the accept thread as the sandbox host process has already been 253 // Start the accept thread as the sandbox host process has already been
256 // spawned. 254 // spawned.
257 embedded_test_server()->StartAcceptingConnections(); 255 embedded_test_server()->StartAcceptingConnections();
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
935 MakeKioskApp("App Name", "1.0", kNoneAutoLaucnhedAppId, 933 MakeKioskApp("App Name", "1.0", kNoneAutoLaucnhedAppId,
936 kTestCases[i].required_platform_version); 934 kTestCases[i].required_platform_version);
937 EXPECT_TRUE(manager()->IsPlatformCompliantWithApp(app.get())) 935 EXPECT_TRUE(manager()->IsPlatformCompliantWithApp(app.get()))
938 << "Test case for non auto launch app: " << i 936 << "Test case for non auto launch app: " << i
939 << ", required_platform_version=" 937 << ", required_platform_version="
940 << kTestCases[i].required_platform_version; 938 << kTestCases[i].required_platform_version;
941 } 939 }
942 } 940 }
943 941
944 } // namespace chromeos 942 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698