Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: chrome/browser/chromeos/login/screens/network_screen_browsertest.cc

Issue 2957983002: Remove pointless InProcessBrowserTest calls. (Closed)
Patch Set: build Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/screens/network_screen.h" 5 #include "chrome/browser/chromeos/login/screens/network_screen.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 ASSERT_EQ(WizardController::default_controller()->current_screen(), 66 ASSERT_EQ(WizardController::default_controller()->current_screen(),
67 network_screen_); 67 network_screen_);
68 network_screen_->base_screen_delegate_ = mock_base_screen_delegate_.get(); 68 network_screen_->base_screen_delegate_ = mock_base_screen_delegate_.get();
69 ASSERT_TRUE(network_screen_->view_ != nullptr); 69 ASSERT_TRUE(network_screen_->view_ != nullptr);
70 70
71 mock_network_state_helper_ = new login::MockNetworkStateHelper; 71 mock_network_state_helper_ = new login::MockNetworkStateHelper;
72 SetDefaultNetworkStateHelperExpectations(); 72 SetDefaultNetworkStateHelperExpectations();
73 network_screen_->SetNetworkStateHelperForTest(mock_network_state_helper_); 73 network_screen_->SetNetworkStateHelperForTest(mock_network_state_helper_);
74 } 74 }
75 75
76 void TearDownInProcessBrowserTestFixture() override {
77 InProcessBrowserTest::TearDownInProcessBrowserTestFixture();
78 }
79
80 void EmulateContinueButtonExit(NetworkScreen* network_screen) { 76 void EmulateContinueButtonExit(NetworkScreen* network_screen) {
81 EXPECT_CALL(*mock_base_screen_delegate_, 77 EXPECT_CALL(*mock_base_screen_delegate_,
82 OnExit(_, ScreenExitCode::NETWORK_CONNECTED, _)) 78 OnExit(_, ScreenExitCode::NETWORK_CONNECTED, _))
83 .Times(1); 79 .Times(1);
84 EXPECT_CALL(*mock_network_state_helper_, IsConnected()) 80 EXPECT_CALL(*mock_network_state_helper_, IsConnected())
85 .WillOnce(Return(true)); 81 .WillOnce(Return(true));
86 network_screen->OnContinueButtonPressed(); 82 network_screen->OnContinueButtonPressed();
87 content::RunAllPendingInMessageLoop(); 83 content::RunAllPendingInMessageLoop();
88 } 84 }
89 85
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 // EXPECT_FALSE(view_->IsConnecting()); 136 // EXPECT_FALSE(view_->IsConnecting());
141 network_screen_->OnConnectionTimeout(); 137 network_screen_->OnConnectionTimeout();
142 138
143 // Close infobubble with error message - it makes the test stable. 139 // Close infobubble with error message - it makes the test stable.
144 // EXPECT_FALSE(view_->IsContinueEnabled()); 140 // EXPECT_FALSE(view_->IsContinueEnabled());
145 // EXPECT_FALSE(view_->IsConnecting()); 141 // EXPECT_FALSE(view_->IsConnecting());
146 // view_->ClearErrors(); 142 // view_->ClearErrors();
147 } 143 }
148 144
149 } // namespace chromeos 145 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698