chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc - Issue 2957983002: Remove pointless InProcessBrowserTest calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc

Issue 2957983002: Remove pointless InProcessBrowserTest calls. (Closed)

Patch Set: build Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc

diff --git a/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc b/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc

index 1695a3a6354182849d4a46bfad5e73bbbca6b854..2954f7b06d2e9694d9a193a67a56dedd8ea9246d 100644

--- a/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc

+++ b/chrome/browser/safe_browsing/chrome_cleaner/settings_resetter_browsertest_win.cc

@@ -79,8 +79,6 @@ void SetCompletedState(DWORD value) {

class ChromeCleanerTagForResettingTest : public InProcessBrowserTest {

public:

void SetUpInProcessBrowserTestFixture() override {

- InProcessBrowserTest::SetUpInProcessBrowserTestFixture();

scoped_feature_list_.InitAndEnableFeature(kInBrowserCleanerUIFeature);

}

@@ -152,8 +150,6 @@ class ChromeCleanerResetTaggedProfilesTest

public ::testing::WithParamInterface<CleanupCompletionState> {

public:

void SetUpInProcessBrowserTestFixture() override {

- InProcessBrowserTest::SetUpInProcessBrowserTestFixture();

completion_state_ = GetParam();

ASSERT_TRUE(completion_state_ >= CleanupCompletionState::kNotAvailable &&

completion_state_ <= CleanupCompletionState::kInvalidValue);