Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Side by Side Diff: chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc

Issue 2957983002: Remove pointless InProcessBrowserTest calls. (Closed)
Patch Set: build Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/image_fetcher/core/image_fetcher_impl.h" 5 #include "components/image_fetcher/core/image_fetcher_impl.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 65
66 class ImageFetcherImplBrowserTest : public InProcessBrowserTest { 66 class ImageFetcherImplBrowserTest : public InProcessBrowserTest {
67 protected: 67 protected:
68 ImageFetcherImplBrowserTest() 68 ImageFetcherImplBrowserTest()
69 : num_callback_valid_called_(0), num_callback_null_called_(0) { 69 : num_callback_valid_called_(0), num_callback_null_called_(0) {
70 test_server_.ServeFilesFromSourceDirectory(base::FilePath(kDocRoot)); 70 test_server_.ServeFilesFromSourceDirectory(base::FilePath(kDocRoot));
71 } 71 }
72 72
73 void SetUpInProcessBrowserTestFixture() override { 73 void SetUpInProcessBrowserTestFixture() override {
74 ASSERT_TRUE(test_server_.Start()); 74 ASSERT_TRUE(test_server_.Start());
75 InProcessBrowserTest::SetUpInProcessBrowserTestFixture();
76 } 75 }
77 76
78 ImageFetcherImpl* CreateImageFetcher() { 77 ImageFetcherImpl* CreateImageFetcher() {
79 ImageFetcherImpl* fetcher = 78 ImageFetcherImpl* fetcher =
80 new ImageFetcherImpl(base::MakeUnique<suggestions::ImageDecoderImpl>(), 79 new ImageFetcherImpl(base::MakeUnique<suggestions::ImageDecoderImpl>(),
81 browser()->profile()->GetRequestContext()); 80 browser()->profile()->GetRequestContext());
82 fetcher->SetImageFetcherDelegate(&delegate_); 81 fetcher->SetImageFetcherDelegate(&delegate_);
83 return fetcher; 82 return fetcher;
84 } 83 }
85 84
(...skipping 20 matching lines...) Expand all
106 TRAFFIC_ANNOTATION_FOR_TESTS); 105 TRAFFIC_ANNOTATION_FOR_TESTS);
107 run_loop.Run(); 106 run_loop.Run();
108 } 107 }
109 108
110 int num_callback_valid_called_; 109 int num_callback_valid_called_;
111 int num_callback_null_called_; 110 int num_callback_null_called_;
112 111
113 net::EmbeddedTestServer test_server_; 112 net::EmbeddedTestServer test_server_;
114 TestImageFetcherDelegate delegate_; 113 TestImageFetcherDelegate delegate_;
115 114
115 private:
116 DISALLOW_COPY_AND_ASSIGN(ImageFetcherImplBrowserTest); 116 DISALLOW_COPY_AND_ASSIGN(ImageFetcherImplBrowserTest);
117 }; 117 };
118 118
119 IN_PROC_BROWSER_TEST_F(ImageFetcherImplBrowserTest, NormalFetch) { 119 IN_PROC_BROWSER_TEST_F(ImageFetcherImplBrowserTest, NormalFetch) {
120 GURL image_url(test_server_.GetURL(kTestImagePath).spec()); 120 GURL image_url(test_server_.GetURL(kTestImagePath).spec());
121 StartOrQueueNetworkRequestHelper(image_url); 121 StartOrQueueNetworkRequestHelper(image_url);
122 122
123 EXPECT_EQ(1, num_callback_valid_called_); 123 EXPECT_EQ(1, num_callback_valid_called_);
124 EXPECT_EQ(0, num_callback_null_called_); 124 EXPECT_EQ(0, num_callback_null_called_);
125 EXPECT_EQ(1, delegate_.num_delegate_valid_called()); 125 EXPECT_EQ(1, delegate_.num_delegate_valid_called());
(...skipping 17 matching lines...) Expand all
143 GURL invalid_image_url(test_server_.GetURL(kInvalidImagePath).spec()); 143 GURL invalid_image_url(test_server_.GetURL(kInvalidImagePath).spec());
144 StartOrQueueNetworkRequestHelper(invalid_image_url); 144 StartOrQueueNetworkRequestHelper(invalid_image_url);
145 145
146 EXPECT_EQ(0, num_callback_valid_called_); 146 EXPECT_EQ(0, num_callback_valid_called_);
147 EXPECT_EQ(1, num_callback_null_called_); 147 EXPECT_EQ(1, num_callback_null_called_);
148 EXPECT_EQ(0, delegate_.num_delegate_valid_called()); 148 EXPECT_EQ(0, delegate_.num_delegate_valid_called());
149 EXPECT_EQ(1, delegate_.num_delegate_null_called()); 149 EXPECT_EQ(1, delegate_.num_delegate_null_called());
150 } 150 }
151 151
152 } // namespace suggestions 152 } // namespace suggestions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698