Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper_browsertest.cc

Issue 2957983002: Remove pointless InProcessBrowserTest calls. (Closed)
Patch Set: build Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/sync/profile_signin_confirmation_helper.h" 5 #include "chrome/browser/ui/sync/profile_signin_confirmation_helper.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "chrome/browser/first_run/first_run.h" 12 #include "chrome/browser/first_run/first_run.h"
13 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
14 #include "chrome/common/chrome_switches.h" 14 #include "chrome/common/chrome_switches.h"
15 #include "chrome/test/base/in_process_browser_test.h" 15 #include "chrome/test/base/in_process_browser_test.h"
16 #include "content/public/test/test_launcher.h" 16 #include "content/public/test/test_launcher.h"
17 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
18 18
19 class ProfileSigninConfirmationHelperBrowserTest : public InProcessBrowserTest { 19 class ProfileSigninConfirmationHelperBrowserTest : public InProcessBrowserTest {
20 public: 20 public:
21 ProfileSigninConfirmationHelperBrowserTest() {} 21 ProfileSigninConfirmationHelperBrowserTest() {}
22 22
23 void SetUpCommandLine(base::CommandLine* command_line) override { 23 void SetUpCommandLine(base::CommandLine* command_line) override {
24 // Force the first-run flow to trigger autoimport. 24 // Force the first-run flow to trigger autoimport.
25 InProcessBrowserTest::SetUpCommandLine(command_line);
26 command_line->AppendSwitch(switches::kForceFirstRun); 25 command_line->AppendSwitch(switches::kForceFirstRun);
27 } 26 }
28 27
29 private: 28 private:
30 DISALLOW_COPY_AND_ASSIGN(ProfileSigninConfirmationHelperBrowserTest); 29 DISALLOW_COPY_AND_ASSIGN(ProfileSigninConfirmationHelperBrowserTest);
31 }; 30 };
32 31
33 // http://crbug.com/321302 32 // http://crbug.com/321302
34 #if defined(GOOGLE_CHROME_BUILD) && (defined(OS_MACOSX) || defined(OS_LINUX)) 33 #if defined(GOOGLE_CHROME_BUILD) && (defined(OS_MACOSX) || defined(OS_LINUX))
35 #define MAYBE_HasNotBeenShutdown DISABLED_HasNotBeenShutdown 34 #define MAYBE_HasNotBeenShutdown DISABLED_HasNotBeenShutdown
(...skipping 11 matching lines...) Expand all
47 // http://crbug.com/321302 46 // http://crbug.com/321302
48 #if defined(GOOGLE_CHROME_BUILD) && (defined(OS_MACOSX) || defined(OS_LINUX)) 47 #if defined(GOOGLE_CHROME_BUILD) && (defined(OS_MACOSX) || defined(OS_LINUX))
49 #define MAYBE_HasNoSyncedExtensions DISABLED_HasNoSyncedExtensions 48 #define MAYBE_HasNoSyncedExtensions DISABLED_HasNoSyncedExtensions
50 #else 49 #else
51 #define MAYBE_HasNoSyncedExtensions HasNoSyncedExtensions 50 #define MAYBE_HasNoSyncedExtensions HasNoSyncedExtensions
52 #endif 51 #endif
53 IN_PROC_BROWSER_TEST_F(ProfileSigninConfirmationHelperBrowserTest, 52 IN_PROC_BROWSER_TEST_F(ProfileSigninConfirmationHelperBrowserTest,
54 MAYBE_HasNoSyncedExtensions) { 53 MAYBE_HasNoSyncedExtensions) {
55 EXPECT_FALSE(ui::HasSyncedExtensions(browser()->profile())); 54 EXPECT_FALSE(ui::HasSyncedExtensions(browser()->profile()));
56 } 55 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698