Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2952163002: Remove InProcessBrowserTest::SetUpOnMainThread() calls. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 5 months ago
Reviewers:
benwells
CC:
chromium-reviews, dominickn+watch_chromium.org, jam, yusukes+watch_chromium.org, rogerm+autofillwatch_chromium.org, hidehiko+watch_chromium.org, browser-components-watch_chromium.org, poromov+watch_chromium.org, dougt+watch_chromium.org, lhchavez+watch_chromium.org, dmazzoni+watch_chromium.org, mfoltz+watch_chromium.org, vakh+watch_chromium.org, timvolodine, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, awdf+watch_chromium.org, joenotcharles+watch_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, sebsg+autofillwatch_chromium.org, achuith+watch_chromium.org, raymes+watch_chromium.org, net-reviews_chromium.org, Peter Beverloo, je_julie, darin-cc_chromium.org, csharp+watch_chromium.org, chfremer+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, johnme+watch_chromium.org, alemate+watch_chromium.org, victorhsieh+watch_chromium.org, rouslan+autofill_chromium.org, speed-metrics-reviews_chromium.org, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, loading-reviews_chromium.org, aleventhal+watch_chromium.org, oshima+watch_chromium.org, rdsmith+watch_chromium.org, mlamouri+watch-permissions_chromium.org, Matt Giuca, elijahtaylor+arcwatch_chromium.org, loading-reviews+metrics_chromium.org, feature-media-reviews_chromium.org, mathp+autofillwatch_chromium.org, tfarina, nektar+watch_chromium.org, csharrison+watch_chromium.org, imcheng+watch_chromium.org, pkotwicz+watch_chromium.org, mmenke, dtseng+watch_chromium.org, mac-reviews_chromium.org, estade+watch_chromium.org, zpeng+watch_chromium.org, ftirelo+watch_chromium.org, alito+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove InProcessBrowserTest::SetUpOnMainThread() calls. InProcessBrowserTest is the base class and its SetUpOnMainThread() method does not do anything. Review-Url: https://codereview.chromium.org/2952163002 Cr-Commit-Position: refs/heads/master@{#482692} Committed: https://chromium.googlesource.com/chromium/src/+/b89821dd66c48e4e4aefaebd8c51fca7e85462e8

Patch Set 1 #

Patch Set 2 : lint #

Total comments: 6

Patch Set 3 : nits #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -69 lines) Patch
M chrome/browser/app_controller_mac_browsertest.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/banners/app_banner_manager_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/budget_service/budget_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_live_site_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/mixin_based_browser_test.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_distiller/tab_utils_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/domain_reliability/browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/installable/installable_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/io_thread_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/page_load_metrics/observers/multi_tab_loading_page_load_metrics_observer_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_request_manager_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permissions_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prefetch/prefetch_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sessions/tab_restore_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/speech_recognizer_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_test.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/perf/mach_ports_performancetest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 2957983002 Patch 1
Issue 2957983002 Patch 20001
Issue 2957983002 Patch 40001

Messages

Total messages: 18 (11 generated)
Lei Zhang
3 years, 6 months ago (2017-06-22 14:48:09 UTC) #6
benwells
lgtm with some nits https://codereview.chromium.org/2952163002/diff/20001/chrome/browser/app_controller_mac_browsertest.mm File chrome/browser/app_controller_mac_browsertest.mm (right): https://codereview.chromium.org/2952163002/diff/20001/chrome/browser/app_controller_mac_browsertest.mm#newcode436 chrome/browser/app_controller_mac_browsertest.mm:436: InProcessBrowserTest::SetUpCommandLine(command_line); Nit: may as well ...
3 years, 6 months ago (2017-06-23 03:10:16 UTC) #7
Lei Zhang
So if I get rid of all the "bad" examples, nobody will ever copy + ...
3 years, 5 months ago (2017-06-27 07:06:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952163002/60001
3 years, 5 months ago (2017-06-27 07:06:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/443147)
3 years, 5 months ago (2017-06-27 07:53:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2952163002/60001
3 years, 5 months ago (2017-06-27 17:40:59 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 18:47:30 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b89821dd66c48e4e4aefaebd8c51...

Powered by Google App Engine
This is Rietveld 408576698