Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: chrome/browser/chromeos/login/mixin_based_browser_test.cc

Issue 2957983002: Remove pointless InProcessBrowserTest calls. (Closed)
Patch Set: build Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/mixin_based_browser_test.cc
diff --git a/chrome/browser/chromeos/login/mixin_based_browser_test.cc b/chrome/browser/chromeos/login/mixin_based_browser_test.cc
index fdeaae4532cce8364a06655eb59e389bce7f38b1..a5b9ee032c6129c4065e370c37e19e455dec1f1d 100644
--- a/chrome/browser/chromeos/login/mixin_based_browser_test.cc
+++ b/chrome/browser/chromeos/login/mixin_based_browser_test.cc
@@ -20,16 +20,12 @@ void MixinBasedBrowserTest::SetUpCommandLine(base::CommandLine* command_line) {
setup_was_launched_ = true;
for (const auto& mixin : mixins_)
mixin->SetUpCommandLine(command_line);
-
- InProcessBrowserTest::SetUpCommandLine(command_line);
}
void MixinBasedBrowserTest::SetUpInProcessBrowserTestFixture() {
setup_was_launched_ = true;
for (const auto& mixin : mixins_)
mixin->SetUpInProcessBrowserTestFixture();
-
- InProcessBrowserTest::SetUpInProcessBrowserTestFixture();
}
void MixinBasedBrowserTest::SetUpOnMainThread() {
@@ -39,12 +35,11 @@ void MixinBasedBrowserTest::SetUpOnMainThread() {
}
void MixinBasedBrowserTest::TearDownOnMainThread() {
- InProcessBrowserTest::TearDownOnMainThread();
for (const auto& mixin : base::Reversed(mixins_))
mixin->TearDownInProcessBrowserTestFixture();
}
+
void MixinBasedBrowserTest::TearDownInProcessBrowserTestFixture() {
- InProcessBrowserTest::TearDownInProcessBrowserTestFixture();
for (const auto& mixin : base::Reversed(mixins_))
mixin->TearDownInProcessBrowserTestFixture();
}

Powered by Google App Engine
This is Rietveld 408576698