Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)

Created:
3 years, 6 months ago by nikhil.sahni
Modified:
3 years, 6 months ago
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Making CSD ReportType enum consistent. Currently the enums are defined inconsistently and Some has URL_as prefix, and some has _URL as suffix BUG=728741 Review-Url: https://codereview.chromium.org/2925693003 Cr-Commit-Position: refs/heads/master@{#479002} Committed: https://chromium.googlesource.com/chromium/src/+/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Patch Set 3 : Fixed Unit test compilation error. #

Patch Set 4 : Handling SBThreatType enums as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -73 lines) Patch
M chrome/browser/safe_browsing/chrome_password_protection_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/local_database_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/threat_details_unittest.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ssl/security_state_tab_helper.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_browsing/base_blocking_page.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/safe_browsing/base_ping_manager.cc View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M components/safe_browsing/base_ping_manager_unittest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M components/safe_browsing/browser/threat_details.cc View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M components/safe_browsing/csd.proto View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_local_database_manager_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M components/security_interstitials/content/unsafe_resource.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/security_interstitials/content/unsafe_resource.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 44 (23 generated)
Srirama
Please modify in unit_test files as well.
3 years, 6 months ago (2017-06-06 11:50:18 UTC) #3
Srirama
peer review is fine.
3 years, 6 months ago (2017-06-06 12:37:18 UTC) #4
Jialiu Lin
Thanks for helping out with safe browsing code! Since you're there, do you mind making ...
3 years, 6 months ago (2017-06-06 18:57:38 UTC) #9
nikhil.sahni
On 2017/06/06 18:57:38, Jialiu Lin wrote: > Thanks for helping out with safe browsing code! ...
3 years, 6 months ago (2017-06-07 05:26:42 UTC) #12
nikhil.sahni
Changes are done.Thanks.
3 years, 6 months ago (2017-06-07 09:49:30 UTC) #13
Jialiu Lin
LGTM. Thanks for making this change!
3 years, 6 months ago (2017-06-08 20:51:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925693003/60001
3 years, 6 months ago (2017-06-09 06:55:46 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/459920)
3 years, 6 months ago (2017-06-09 07:03:44 UTC) #22
nikhil.sahni
I think it failed for below: ** Presubmit ERRORS ** Missing LGTM from an OWNER ...
3 years, 6 months ago (2017-06-09 07:45:48 UTC) #23
nikhil.sahni
I think it failed for below: ** Presubmit ERRORS ** Missing LGTM from an OWNER ...
3 years, 6 months ago (2017-06-09 07:45:49 UTC) #24
Jialiu Lin
+estark@ for owner review of chrome/browser/ssl/security_state_tab_helper.cc chrome/browser/ui/webui/interstitials/interstitial_ui.cc
3 years, 6 months ago (2017-06-09 16:27:40 UTC) #26
estark
On 2017/06/09 16:27:40, Jialiu Lin wrote: > +estark@ for owner review of > chrome/browser/ssl/security_state_tab_helper.cc > ...
3 years, 6 months ago (2017-06-09 17:04:24 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925693003/60001
3 years, 6 months ago (2017-06-12 04:52:45 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/460994)
3 years, 6 months ago (2017-06-12 05:01:33 UTC) #31
nikhil.sahni
Hi Jialiu Please add the OWNER for below as well,thanks!!! ** Presubmit ERRORS ** Missing ...
3 years, 6 months ago (2017-06-12 05:11:16 UTC) #32
nikhil.sahni
Adding owner For the file subresource_filter_safe_browsing_activation_throttle_unittest.cc
3 years, 6 months ago (2017-06-12 05:16:03 UTC) #34
Jialiu Lin
- shivanisha@ + melandory@ for owner review of components/subresource_filter/* Thanks!
3 years, 6 months ago (2017-06-12 17:34:14 UTC) #36
Jialiu Lin
+ melandory@ for owner review of components/subresource_filter/*
3 years, 6 months ago (2017-06-12 17:34:53 UTC) #38
melandory
On 2017/06/12 17:34:53, Jialiu Lin wrote: > + melandory@ for owner review of components/subresource_filter/* subresource_filter ...
3 years, 6 months ago (2017-06-13 12:13:36 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925693003/60001
3 years, 6 months ago (2017-06-13 12:50:05 UTC) #41
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 14:03:11 UTC) #44
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/70433a95ffaa5bf34f0dbed3466e...

Powered by Google App Engine
This is Rietveld 408576698