Making CSD ReportType enum consistent.

Making CSD ReportType enum consistent.

Currently the enums are defined inconsistently and
Some has URL_as prefix, and some has _URL as suffix

BUG=728741
Review-Url: https://codereview.chromium.org/2925693003
Cr-Commit-Position: refs/heads/master@{#479002}
Committed: https://chromium.googlesource.com/chromium/src/+/70433a95ffaa5bf34f0dbed3466ea36573ba6d4a

[nikhil.sahni, 2017-06-06 10:33:39]

Description was changed from

==========
Making CSD ReportType enum consistent.

Currently the enums are defined inconsistently and
Some has URL_as prefix, and some has _URL as suffix

BUG=728741
==========

to

==========
Making CSD ReportType enum consistent.

Currently the enums are defined inconsistently and
Some has URL_as prefix, and some has _URL as suffix

BUG=728741

R=SamsungPeerReview
==========

[nikhil.sahni, 2017-06-06 10:33:40]

nikhil.sahni@samsung.com changed reviewers:
+ shanmuga.m@samsung.com, srirama.m@samsung.com

[Srirama, 2017-06-06 11:50:18]

Please modify in unit_test files as well.

[Srirama, 2017-06-06 12:37:18]

peer review is fine.

[nikhil.sahni, 2017-06-06 12:39:34]

Description was changed from

==========
Making CSD ReportType enum consistent.

Currently the enums are defined inconsistently and
Some has URL_as prefix, and some has _URL as suffix

BUG=728741

R=SamsungPeerReview
==========

to

==========
Making CSD ReportType enum consistent.

Currently the enums are defined inconsistently and
Some has URL_as prefix, and some has _URL as suffix

BUG=728741
==========

[nikhil.sahni, 2017-06-06 12:39:34]

nikhil.sahni@samsung.com changed reviewers:
+ jialiul@chromium.org

[Jialiu Lin, 2017-06-06 18:21:09]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 18:21:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2017-06-06 18:57:38]

Thanks for helping out with safe browsing code! 
Since you're there, do you mind making enum SBThreatType more consistent in
components/safe_browsing_db/v4_protocol_manager_util.h ?

Thank you!

[commit-bot: I haz the power, 2017-06-06 19:26:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 19:26:12]

Dry run: This issue passed the CQ dry run.

[nikhil.sahni, 2017-06-07 05:26:42]

On 2017/06/06 18:57:38, Jialiu Lin wrote:
> Thanks for helping out with safe browsing code! 
> Since you're there, do you mind making enum SBThreatType more consistent in
> components/safe_browsing_db/v4_protocol_manager_util.h ?
> 
> Thank you!


Sure I will do that !!!. Thanks. !!!

[nikhil.sahni, 2017-06-07 09:49:30]

Changes are done.Thanks.

[Jialiu Lin, 2017-06-07 18:27:04]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 18:27:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 19:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 19:58:03]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2017-06-08 20:51:07]

LGTM. Thanks for making this change!

[nikhil.sahni, 2017-06-09 06:55:36]

The CQ bit was checked by nikhil.sahni@samsung.com

[commit-bot: I haz the power, 2017-06-09 06:55:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 07:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 07:03:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nikhil.sahni, 2017-06-09 07:45:48]

I think it failed for below:

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/ssl/security_state_tab_helper.cc
    chrome/browser/ui/webui/interstitials/interstitial_ui.cc
   
components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

[nikhil.sahni, 2017-06-09 07:45:49]

I think it failed for below:

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/browser/ssl/security_state_tab_helper.cc
    chrome/browser/ui/webui/interstitials/interstitial_ui.cc
   
components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

[Jialiu Lin, 2017-06-09 16:27:39]

jialiul@chromium.org changed reviewers:
+ estark@chromium.org

[Jialiu Lin, 2017-06-09 16:27:40]

+estark@ for owner review of
chrome/browser/ssl/security_state_tab_helper.cc
chrome/browser/ui/webui/interstitials/interstitial_ui.cc

[estark, 2017-06-09 17:04:24]

On 2017/06/09 16:27:40, Jialiu Lin wrote:
> +estark@ for owner review of
> chrome/browser/ssl/security_state_tab_helper.cc
> chrome/browser/ui/webui/interstitials/interstitial_ui.cc

those files lgtm

[nikhil.sahni, 2017-06-12 04:52:34]

The CQ bit was checked by nikhil.sahni@samsung.com

[commit-bot: I haz the power, 2017-06-12 04:52:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 05:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 05:01:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nikhil.sahni, 2017-06-12 05:11:16]

Hi Jialiu

Please add the OWNER for below as well,thanks!!! 

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
   
components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

[nikhil.sahni, 2017-06-12 05:16:02]

nikhil.sahni@samsung.com changed reviewers:
+ shivanisha@chromium.org

[nikhil.sahni, 2017-06-12 05:16:03]

Adding owner For the file
subresource_filter_safe_browsing_activation_throttle_unittest.cc

[Jialiu Lin, 2017-06-12 17:34:13]

jialiul@chromium.org changed reviewers:
- shivanisha@chromium.org

[Jialiu Lin, 2017-06-12 17:34:14]

- shivanisha@
+ melandory@ for owner review of components/subresource_filter/*

Thanks!

[Jialiu Lin, 2017-06-12 17:34:53]

jialiul@chromium.org changed reviewers:
+ melandory@chromium.org

[Jialiu Lin, 2017-06-12 17:34:53]

+ melandory@ for owner review of components/subresource_filter/*

[melandory, 2017-06-13 12:13:36]

On 2017/06/12 17:34:53, Jialiu Lin wrote:
> + melandory@ for owner review of components/subresource_filter/*

subresource_filter lgtm

[nikhil.sahni, 2017-06-13 12:49:46]

The CQ bit was checked by nikhil.sahni@samsung.com

[commit-bot: I haz the power, 2017-06-13 12:50:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 14:02:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497358186670360,
"parent_rev": "74d41be00cca6f72f0c4fd57afe7aa6ffef6a4fc", "commit_rev":
"70433a95ffaa5bf34f0dbed3466ea36573ba6d4a"}

[commit-bot: I haz the power, 2017-06-13 14:03:10]

Description was changed from

==========
Making CSD ReportType enum consistent.

Currently the enums are defined inconsistently and
Some has URL_as prefix, and some has _URL as suffix

BUG=728741
==========

to

==========
Making CSD ReportType enum consistent.

Currently the enums are defined inconsistently and
Some has URL_as prefix, and some has _URL as suffix

BUG=728741

Review-Url: https://codereview.chromium.org/2925693003
Cr-Commit-Position: refs/heads/master@{#479002}
Committed:
https://chromium.googlesource.com/chromium/src/+/70433a95ffaa5bf34f0dbed3466e...
==========

[commit-bot: I haz the power, 2017-06-13 14:03:11]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/70433a95ffaa5bf34f0dbed3466e...