Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: components/safe_browsing_db/v4_protocol_manager_util.h

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)
Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_protocol_manager_util.h
diff --git a/components/safe_browsing_db/v4_protocol_manager_util.h b/components/safe_browsing_db/v4_protocol_manager_util.h
index 54b522503d8cafe7b5719aaeaf238b389b907a9a..944f2f1211eda201c81bb447c09fe61caf04dd44 100644
--- a/components/safe_browsing_db/v4_protocol_manager_util.h
+++ b/components/safe_browsing_db/v4_protocol_manager_util.h
@@ -93,18 +93,18 @@ enum SBThreatType {
SB_THREAT_TYPE_URL_UNWANTED,
// The download URL is malware.
- SB_THREAT_TYPE_BINARY_MALWARE_URL,
+ SB_THREAT_TYPE_URL_BINARY_MALWARE,
// Url detected by the client-side phishing model. Note that unlike the
// above values, this does not correspond to a downloaded list.
- SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL,
+ SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING,
// The Chrome extension or app (given by its ID) is malware.
SB_THREAT_TYPE_EXTENSION,
// Url detected by the client-side malware IP list. This IP list is part
// of the client side detection model.
- SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL,
+ SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE,
// Url leads to a blacklisted resource script. Note that no warnings should be
// shown on this threat type, but an incident report might be sent.
@@ -120,7 +120,7 @@ enum SBThreatType {
SB_THREAT_TYPE_CSD_WHITELIST,
// Url detected by password protection service.
- SB_THREAT_TYPE_PASSWORD_PROTECTION_PHISHING_URL,
+ SB_THREAT_TYPE_URL_PASSWORD_PROTECTION_PHISHING,
};
// The information required to uniquely identify each list the client is

Powered by Google App Engine
This is Rietveld 408576698