chrome/browser/safe_browsing/client_side_detection_host.cc - Issue 2925693003: Making CSD ReportType enum consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)

Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/client_side_detection_host.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host.cc b/chrome/browser/safe_browsing/client_side_detection_host.cc

index 838bc9dd920e488eda7236efc83c785606b34673..6d31aaafc0ca03c65a1b798a810047714842be97 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host.cc

@@ -565,7 +565,7 @@ void ClientSideDetectionHost::MaybeShowPhishingWarning(GURL phishing_url,

resource.url = phishing_url;

resource.original_url = phishing_url;

resource.is_subresource = false;

- resource.threat_type = SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL;

+ resource.threat_type = SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING;

resource.threat_source =

safe_browsing::ThreatSource::CLIENT_SIDE_DETECTION;

resource.web_contents_getter = safe_browsing::SafeBrowsingUIManager::

@@ -601,7 +601,7 @@ void ClientSideDetectionHost::MaybeShowMalwareWarning(GURL original_url,

resource.url = malware_url;

resource.original_url = original_url;

resource.is_subresource = (malware_url.host() != original_url.host());

- resource.threat_type = SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL;

+ resource.threat_type = SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE;

resource.threat_source =

safe_browsing::ThreatSource::CLIENT_SIDE_DETECTION;

resource.web_contents_getter = safe_browsing::SafeBrowsingUIManager::