components/safe_browsing_db/v4_local_database_manager.cc - Issue 2925693003: Making CSD ReportType enum consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_local_database_manager.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)

Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/v4_local_database_manager.cc

diff --git a/components/safe_browsing_db/v4_local_database_manager.cc b/components/safe_browsing_db/v4_local_database_manager.cc

index c17dbde9283d0381364d87d78d1749a3b830fa78..3e3c1962da5ff47d7cde0b5cabe9e988b906b3a5 100644

--- a/components/safe_browsing_db/v4_local_database_manager.cc

+++ b/components/safe_browsing_db/v4_local_database_manager.cc

@@ -69,7 +69,7 @@ ListInfos GetListInfos() {

// The GetUrlMalBinId list is not working for non-GoogleChrome builds

// currently so making it Chrome-only. See: http://crbug.com/728757

ListInfo(kSyncOnlyOnChromeBuilds, "UrlMalBin.store", GetUrlMalBinId(),

- SB_THREAT_TYPE_BINARY_MALWARE_URL),

+ SB_THREAT_TYPE_URL_BINARY_MALWARE),

ListInfo(kSyncAlways, "ChromeExtMalware.store", GetChromeExtMalwareId(),

SB_THREAT_TYPE_EXTENSION),

ListInfo(kSyncOnlyOnChromeBuilds, "ChromeUrlClientIncident.store",