chrome/browser/safe_browsing/chrome_password_protection_service.cc - Issue 2925693003: Making CSD ReportType enum consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/chrome_password_protection_service.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)

Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/chrome_password_protection_service.cc

diff --git a/chrome/browser/safe_browsing/chrome_password_protection_service.cc b/chrome/browser/safe_browsing/chrome_password_protection_service.cc

index 63168e7a331f686676b5cdad6f2d84817c6821d8..fdb621c097a03b03a5c60efe9c35a99e39e250f9 100644

--- a/chrome/browser/safe_browsing/chrome_password_protection_service.cc

+++ b/chrome/browser/safe_browsing/chrome_password_protection_service.cc

@@ -148,7 +148,7 @@ void ChromePasswordProtectionService::ShowPhishingInterstitial(

resource.url = phishing_url;

resource.original_url = phishing_url;

resource.is_subresource = false;

- resource.threat_type = SB_THREAT_TYPE_PASSWORD_PROTECTION_PHISHING_URL;

+ resource.threat_type = SB_THREAT_TYPE_URL_PASSWORD_PROTECTION_PHISHING;

resource.threat_source =

safe_browsing::ThreatSource::PASSWORD_PROTECTION_SERVICE;

resource.web_contents_getter =

« no previous file with comments | « no previous file | chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc » ('j') | no next file with comments »