Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: components/safe_browsing/base_ping_manager.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)
Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/base_ping_manager.cc
diff --git a/components/safe_browsing/base_ping_manager.cc b/components/safe_browsing/base_ping_manager.cc
index d397c2acd70956799f76c4d8538b082ed834c3f2..cc89412fd98fd3804884fa169eede120b7a71844 100644
--- a/components/safe_browsing/base_ping_manager.cc
+++ b/components/safe_browsing/base_ping_manager.cc
@@ -199,11 +199,11 @@ GURL BasePingManager::SafeBrowsingHitUrl(
DCHECK(hit_report.threat_type == SB_THREAT_TYPE_URL_MALWARE ||
hit_report.threat_type == SB_THREAT_TYPE_URL_PHISHING ||
hit_report.threat_type == SB_THREAT_TYPE_URL_UNWANTED ||
- hit_report.threat_type == SB_THREAT_TYPE_BINARY_MALWARE_URL ||
- hit_report.threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL ||
- hit_report.threat_type == SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL ||
+ hit_report.threat_type == SB_THREAT_TYPE_URL_BINARY_MALWARE ||
+ hit_report.threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING ||
+ hit_report.threat_type == SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE ||
hit_report.threat_type ==
- SB_THREAT_TYPE_PASSWORD_PROTECTION_PHISHING_URL);
+ SB_THREAT_TYPE_URL_PASSWORD_PROTECTION_PHISHING);
std::string url = ProtocolManagerHelper::ComposeUrl(
url_prefix_, "report", client_name_, version_, std::string(),
hit_report.extended_reporting_level);
@@ -219,16 +219,16 @@ GURL BasePingManager::SafeBrowsingHitUrl(
case SB_THREAT_TYPE_URL_UNWANTED:
threat_list = "uwsblhit";
break;
- case SB_THREAT_TYPE_BINARY_MALWARE_URL:
+ case SB_THREAT_TYPE_URL_BINARY_MALWARE:
threat_list = "binurlhit";
break;
- case SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL:
+ case SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING:
threat_list = "phishcsdhit";
break;
- case SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL:
+ case SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE:
threat_list = "malcsdhit";
break;
- case SB_THREAT_TYPE_PASSWORD_PROTECTION_PHISHING_URL:
+ case SB_THREAT_TYPE_URL_PASSWORD_PROTECTION_PHISHING:
threat_list = "phishpphit";
break;
default:
« no previous file with comments | « components/safe_browsing/base_blocking_page.cc ('k') | components/safe_browsing/base_ping_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698