components/safe_browsing_db/v4_local_database_manager_unittest.cc - Issue 2925693003: Making CSD ReportType enum consistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_local_database_manager_unittest.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)

Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/v4_local_database_manager_unittest.cc

diff --git a/components/safe_browsing_db/v4_local_database_manager_unittest.cc b/components/safe_browsing_db/v4_local_database_manager_unittest.cc

index 5e20cb753068b6b3dc8919faa76c56272dc503ae..489ff7bdb8424f865968f77151c2fead1b1c6a1b 100644

--- a/components/safe_browsing_db/v4_local_database_manager_unittest.cc

+++ b/components/safe_browsing_db/v4_local_database_manager_unittest.cc

@@ -1093,7 +1093,7 @@ TEST_F(V4LocalDatabaseManagerTest, TestCheckDownloadUrlWithOneBlacklisted) {

store_and_hash_prefixes.emplace_back(GetUrlMalBinId(), bad_hash_prefix);

ReplaceV4Database(store_and_hash_prefixes, true /* stores_available */);

- TestClient client(SB_THREAT_TYPE_BINARY_MALWARE_URL, url_chain);

+ TestClient client(SB_THREAT_TYPE_URL_BINARY_MALWARE, url_chain);

EXPECT_FALSE(

v4_local_database_manager_->CheckDownloadUrl(url_chain, &client));

EXPECT_FALSE(client.on_check_download_urls_result_called_);