Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 2925693003: Making CSD ReportType enum consistent. (Closed)
Patch Set: Handling SBThreatType enums as well Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/client_side_detection_host.h" 5 #include "chrome/browser/safe_browsing/client_side_detection_host.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <tuple> 8 #include <tuple>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 UnsafeResource resource; 554 UnsafeResource resource;
555 EXPECT_CALL(*ui_manager_.get(), DisplayBlockingPage(_)) 555 EXPECT_CALL(*ui_manager_.get(), DisplayBlockingPage(_))
556 .WillOnce(SaveArg<0>(&resource)); 556 .WillOnce(SaveArg<0>(&resource));
557 cb.Run(phishing_url, true); 557 cb.Run(phishing_url, true);
558 558
559 base::RunLoop().RunUntilIdle(); 559 base::RunLoop().RunUntilIdle();
560 EXPECT_TRUE(Mock::VerifyAndClear(ui_manager_.get())); 560 EXPECT_TRUE(Mock::VerifyAndClear(ui_manager_.get()));
561 EXPECT_EQ(phishing_url, resource.url); 561 EXPECT_EQ(phishing_url, resource.url);
562 EXPECT_EQ(phishing_url, resource.original_url); 562 EXPECT_EQ(phishing_url, resource.original_url);
563 EXPECT_FALSE(resource.is_subresource); 563 EXPECT_FALSE(resource.is_subresource);
564 EXPECT_EQ(SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL, resource.threat_type); 564 EXPECT_EQ(SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING, resource.threat_type);
565 EXPECT_EQ(ThreatSource::CLIENT_SIDE_DETECTION, resource.threat_source); 565 EXPECT_EQ(ThreatSource::CLIENT_SIDE_DETECTION, resource.threat_source);
566 EXPECT_EQ(web_contents(), resource.web_contents_getter.Run()); 566 EXPECT_EQ(web_contents(), resource.web_contents_getter.Run());
567 567
568 // Make sure the client object will be deleted. 568 // Make sure the client object will be deleted.
569 BrowserThread::PostTask( 569 BrowserThread::PostTask(
570 BrowserThread::IO, FROM_HERE, 570 BrowserThread::IO, FROM_HERE,
571 base::BindOnce(&MockSafeBrowsingUIManager::InvokeOnBlockingPageComplete, 571 base::BindOnce(&MockSafeBrowsingUIManager::InvokeOnBlockingPageComplete,
572 ui_manager_, resource.callback)); 572 ui_manager_, resource.callback));
573 } 573 }
574 574
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 .WillOnce(SaveArg<0>(&resource)); 640 .WillOnce(SaveArg<0>(&resource));
641 641
642 cb.Run(phishing_url, true); // Should have no effect. 642 cb.Run(phishing_url, true); // Should have no effect.
643 cb_other.Run(other_phishing_url, true); // Should show interstitial. 643 cb_other.Run(other_phishing_url, true); // Should show interstitial.
644 644
645 base::RunLoop().RunUntilIdle(); 645 base::RunLoop().RunUntilIdle();
646 EXPECT_TRUE(Mock::VerifyAndClear(ui_manager_.get())); 646 EXPECT_TRUE(Mock::VerifyAndClear(ui_manager_.get()));
647 EXPECT_EQ(other_phishing_url, resource.url); 647 EXPECT_EQ(other_phishing_url, resource.url);
648 EXPECT_EQ(other_phishing_url, resource.original_url); 648 EXPECT_EQ(other_phishing_url, resource.original_url);
649 EXPECT_FALSE(resource.is_subresource); 649 EXPECT_FALSE(resource.is_subresource);
650 EXPECT_EQ(SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL, resource.threat_type); 650 EXPECT_EQ(SB_THREAT_TYPE_URL_CLIENT_SIDE_PHISHING, resource.threat_type);
651 EXPECT_EQ(ThreatSource::CLIENT_SIDE_DETECTION, resource.threat_source); 651 EXPECT_EQ(ThreatSource::CLIENT_SIDE_DETECTION, resource.threat_source);
652 EXPECT_EQ(web_contents(), resource.web_contents_getter.Run()); 652 EXPECT_EQ(web_contents(), resource.web_contents_getter.Run());
653 653
654 // Make sure the client object will be deleted. 654 // Make sure the client object will be deleted.
655 BrowserThread::PostTask( 655 BrowserThread::PostTask(
656 BrowserThread::IO, FROM_HERE, 656 BrowserThread::IO, FROM_HERE,
657 base::BindOnce(&MockSafeBrowsingUIManager::InvokeOnBlockingPageComplete, 657 base::BindOnce(&MockSafeBrowsingUIManager::InvokeOnBlockingPageComplete,
658 ui_manager_, resource.callback)); 658 ui_manager_, resource.callback));
659 } 659 }
660 660
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
853 UnsafeResource resource; 853 UnsafeResource resource;
854 EXPECT_CALL(*ui_manager_.get(), DisplayBlockingPage(_)) 854 EXPECT_CALL(*ui_manager_.get(), DisplayBlockingPage(_))
855 .WillOnce(SaveArg<0>(&resource)); 855 .WillOnce(SaveArg<0>(&resource));
856 cb.Run(malware_landing_url, malware_ip_url, true); 856 cb.Run(malware_landing_url, malware_ip_url, true);
857 857
858 base::RunLoop().RunUntilIdle(); 858 base::RunLoop().RunUntilIdle();
859 EXPECT_TRUE(Mock::VerifyAndClear(ui_manager_.get())); 859 EXPECT_TRUE(Mock::VerifyAndClear(ui_manager_.get()));
860 EXPECT_EQ(malware_ip_url, resource.url); 860 EXPECT_EQ(malware_ip_url, resource.url);
861 EXPECT_EQ(malware_landing_url, resource.original_url); 861 EXPECT_EQ(malware_landing_url, resource.original_url);
862 EXPECT_TRUE(resource.is_subresource); 862 EXPECT_TRUE(resource.is_subresource);
863 EXPECT_EQ(SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL, resource.threat_type); 863 EXPECT_EQ(SB_THREAT_TYPE_URL_CLIENT_SIDE_MALWARE, resource.threat_type);
864 EXPECT_EQ(ThreatSource::CLIENT_SIDE_DETECTION, resource.threat_source); 864 EXPECT_EQ(ThreatSource::CLIENT_SIDE_DETECTION, resource.threat_source);
865 EXPECT_EQ(web_contents(), resource.web_contents_getter.Run()); 865 EXPECT_EQ(web_contents(), resource.web_contents_getter.Run());
866 866
867 // Make sure the client object will be deleted. 867 // Make sure the client object will be deleted.
868 BrowserThread::PostTask( 868 BrowserThread::PostTask(
869 BrowserThread::IO, FROM_HERE, 869 BrowserThread::IO, FROM_HERE,
870 base::BindOnce(&MockSafeBrowsingUIManager::InvokeOnBlockingPageComplete, 870 base::BindOnce(&MockSafeBrowsingUIManager::InvokeOnBlockingPageComplete,
871 ui_manager_, resource.callback)); 871 ui_manager_, resource.callback));
872 } 872 }
873 873
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 EXPECT_EQ(url, resource.url); 1192 EXPECT_EQ(url, resource.url);
1193 EXPECT_EQ(url, resource.original_url); 1193 EXPECT_EQ(url, resource.original_url);
1194 1194
1195 ExpectStartPhishingDetection(NULL); 1195 ExpectStartPhishingDetection(NULL);
1196 1196
1197 // Showing a phishing warning will invalidate all the weak pointers which 1197 // Showing a phishing warning will invalidate all the weak pointers which
1198 // means we will not extract malware features. 1198 // means we will not extract malware features.
1199 ExpectShouldClassifyForMalwareResult(false); 1199 ExpectShouldClassifyForMalwareResult(false);
1200 } 1200 }
1201 } // namespace safe_browsing 1201 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698